core: check excessBlobGas in front #27797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jsvisa <delweng@gmail.com>
|
Myeah, that check doesn't make any sense at all. It's crashing anyway, it's a programming error. Just remove it altogether. |
Yes, for the result it also crashed, but it crashed for a readable message( |
Signed-off-by: jsvisa <delweng@gmail.com>
karalabe
reviewed
Jul 31, 2023
Signed-off-by: jsvisa <delweng@gmail.com>
|
@karalabe PTAL, thanks |
MoonShiesty
pushed a commit
to MoonShiesty/go-ethereum
that referenced
this pull request
Aug 30, 2023
* core: check excessBlobGas in front Signed-off-by: jsvisa <delweng@gmail.com> * core: no need to manual panic Signed-off-by: jsvisa <delweng@gmail.com> * core: no comment Signed-off-by: jsvisa <delweng@gmail.com> --------- Signed-off-by: jsvisa <delweng@gmail.com>
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
* core: check excessBlobGas in front Signed-off-by: jsvisa <delweng@gmail.com> * core: no need to manual panic Signed-off-by: jsvisa <delweng@gmail.com> * core: no comment Signed-off-by: jsvisa <delweng@gmail.com> --------- Signed-off-by: jsvisa <delweng@gmail.com>
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…eum#27797)" This reverts commit cd2e754.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…eum#27797)" This reverts commit cd2e754.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…eum#27797)" This reverts commit cd2e754.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should check ExcessBlobGas before
buyGas, or else an nil pointer error is occurred