-
Notifications
You must be signed in to change notification settings - Fork 20.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: check excessBlobGas in front #27797
Conversation
Signed-off-by: jsvisa <delweng@gmail.com>
Myeah, that check doesn't make any sense at all. It's crashing anyway, it's a programming error. Just remove it altogether. |
Yes, for the result it also crashed, but it crashed for a readable message( |
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
@karalabe PTAL, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
* core: check excessBlobGas in front Signed-off-by: jsvisa <delweng@gmail.com> * core: no need to manual panic Signed-off-by: jsvisa <delweng@gmail.com> * core: no comment Signed-off-by: jsvisa <delweng@gmail.com> --------- Signed-off-by: jsvisa <delweng@gmail.com>
…eum#27797)" This reverts commit cd2e754.
…eum#27797)" This reverts commit cd2e754.
We should check ExcessBlobGas before
buyGas
, or else an nil pointer error is occurred