core/types: add data gas fields in Receipt #27743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
requested review from
zsfelfoldi,
rjl493456442,
karalabe and
holiman
as code owners
karalabe
reviewed
Jul 18, 2023
fjl
commented
Jul 18, 2023
| @@ -63,6 +63,8 @@ type Receipt struct { | |||
| ContractAddress common.Address `json:"contractAddress"` | |||
| GasUsed uint64 `json:"gasUsed" gencodec:"required"` | |||
| EffectiveGasPrice *big.Int `json:"effectiveGasPrice"` // required, but tag omitted for backwards compatibility | |||
| DataGasUsed uint64 `json:"dataGasUsed,omitempty"` | |||
| DataGasPrice *big.Int `json:"dataGasPrice,omitempty"` | |||
There was a problem hiding this comment.
@karalabe says this should be called BlobGasUsed
rjl493456442
approved these changes
Jul 26, 2023
karalabe
approved these changes
Jul 27, 2023
MoonShiesty
pushed a commit
to MoonShiesty/go-ethereum
that referenced
this pull request
Aug 30, 2023
* core/types: add data gas fields in Receipt * core/types: use BlobGas method of tx * core: fix test * core/types: fix receipt tests, add data gas used field test --------- Co-authored-by: Péter Szilágyi <peterke@gmail.com>
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
* core/types: add data gas fields in Receipt * core/types: use BlobGas method of tx * core: fix test * core/types: fix receipt tests, add data gas used field test --------- Co-authored-by: Péter Szilágyi <peterke@gmail.com>
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…)" This reverts commit 4121121.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…)" This reverts commit 4121121.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…)" This reverts commit 4121121.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in receipt changes from the 4844-devnet-7 branch.