Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/ethapi: implement eth_getBlockReceipts #27702

Merged
merged 15 commits into from
Aug 15, 2023
Merged

internal/ethapi: implement eth_getBlockReceipts #27702

merged 15 commits into from
Aug 15, 2023

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Jul 12, 2023

@jsvisa jsvisa marked this pull request as draft July 12, 2023 02:22
s1na
s1na reviewed Jul 12, 2023
View reviewed changes
internal/ethapi/api.go Outdated Show resolved Hide resolved
@s1na
Copy link
Contributor

s1na commented Jul 12, 2023

Also please add to internal/web3ext/web3ext.go.

@jsvisa
Copy link
Contributor Author

jsvisa commented Jul 12, 2023

We need to add test cases, this depends on #27527, so I'll mark this PR ready after #27527 is merged.

@jsvisa jsvisa marked this pull request as ready for review July 13, 2023 16:10
@jsvisa jsvisa requested a review from s1na July 13, 2023 16:10
@jsvisa
Copy link
Contributor Author

jsvisa commented Jul 22, 2023

@s1na @lightclient PTAL

@jsvisa jsvisa mentioned this pull request Jul 22, 2023
Closed
s1na
s1na reviewed Aug 1, 2023
View reviewed changes
internal/jsre/deps/web3.js Outdated Show resolved Hide resolved
@jsvisa
internal/ethapi: marshalReceipt
a84c142 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/ethapi: add GetBlockReceipts RPC
28d7347 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
ethclient: add BlockReceipts client
c658bb5 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/ethapi: dry
cb91e0e 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/web3ext: add js method
7d6c8e1 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/jsre: add inputBlockNumberOrHashFormatter
2bb8cfd 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/web3ext: format input blockNrOrHash
f9b59dd 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/jsre: export inputBlockNumberOrHashFormatter
cf7ea1e 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/ethapi: add a helper to setup receipt backend
ae56e11 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/ethapi: early quit if block is nil
ec72fb3 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/ethapi: add getBlockReceipts testcase
54dfe95 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal: return null if block not found
c0d32b8 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
Revert "internal/jsre: export inputBlockNumberOrHashFormatter"
0f4753e 
This reverts commit cf7ea1e.

Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
Revert "internal/jsre: add inputBlockNumberOrHashFormatter"
db4c6d8 
This reverts commit 2bb8cfd.

Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
Revert "internal/web3ext: format input blockNrOrHash"
7c090aa 
This reverts commit f9b59dd.

Signed-off-by: jsvisa <delweng@gmail.com>
s1na
s1na approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

holiman
holiman approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman
Copy link
Contributor

holiman commented Aug 10, 2023

Should we wait for ethereum/execution-apis#438 before merging? @lightclient what do you say?

@hitdavid
Copy link

Will this PR be merged into the next release please?
Thanks

@fjl fjl removed the status:triage label Aug 15, 2023
@fjl fjl added this to the 1.13.0 milestone Aug 15, 2023
@fjl fjl merged commit f1801a9 into ethereum:master Aug 15, 2023
2 checks passed
@alexqrid alexqrid mentioned this pull request Sep 15, 2023
Closed
@kamikazechaser kamikazechaser mentioned this pull request Sep 20, 2023
Closed
@protolambda protolambda mentioned this pull request Oct 20, 2023
Closed
16 tasks
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@jsvisa @devopsbo3
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
389612c
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "internal/ethapi: implement eth_getBlockReceipts (ethereum#27702…
2a34ed9 
…)"

This reverts commit 389612c.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "internal/ethapi: implement eth_getBlockReceipts (ethereum#27702…
6c249a3 
…)"

This reverts commit 389612c.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "internal/ethapi: implement eth_getBlockReceipts (ethereum#27702…
625ba8e 
…)"

This reverts commit 389612c.
@ajhodges ajhodges mentioned this pull request Nov 16, 2023
Closed
18 tasks
@zlacfzy zlacfzy mentioned this pull request Dec 14, 2023
Merged
@pluto9r pluto9r mentioned this pull request Dec 18, 2023
Closed
marun added a commit to ava-labs/coreth that referenced this pull request Dec 19, 2023
@marun
Copy ethereum/go-ethereum#27702
844fa2e
@marun marun mentioned this pull request Dec 19, 2023
Merged
sduchesneau pushed a commit to streamingfast/go-ethereum that referenced this pull request Dec 19, 2023
@jsvisa @zzzckck
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
f6fb2e9
darioush pushed a commit to ava-labs/coreth that referenced this pull request Dec 20, 2023
@marun
Add support for getBlockReceipts (#429)
f7dd993 
* Copy ethereum/go-ethereum#27702

* Fix TestRPCGetBlockReceipts

* Get ethclient compiling

* Copy ethereum/go-ethereum#28087

* Copy ethereum/go-ethereum#28358
elee1766 pushed a commit to elee1766/go-ethereum that referenced this pull request Dec 23, 2023
@jsvisa @elee1766
internal/ethapi: implement eth_getBlockReceipts (ethereum#27702)
30ecb42
@kallydev kallydev mentioned this pull request Jan 12, 2024
Merged
sduchesneau pushed a commit to streamingfast/go-ethereum that referenced this pull request Feb 26, 2024
@tsahee
Merge upstream PR ethereum#27702
055be78 
upstream PR 27702 implements eth_getBlockReceipts.
To do so it extracts marshalreceipts.

 Conflicts:
  internal/ethapi/api.go

We add a bunch of fields to receipts returned, which required
adding ctx and Backend to marshalReceipts.
@tornadocontrib tornadocontrib mentioned this pull request Mar 25, 2024
Closed
2 tasks
@palango palango mentioned this pull request Mar 26, 2024
Merged
JukLee0ira added a commit to JukLee0ira/XDPoSChain that referenced this pull request May 21, 2024
@JukLee0ira
ethapi: implement eth_getBlockReceipts (ethereum#27702)
7c18850
JukLee0ira added a commit to JukLee0ira/XDPoSChain that referenced this pull request May 21, 2024
@JukLee0ira
ethapi: implement eth_getBlockReceipts (ethereum#27702)
bfdbbe3
JukLee0ira added a commit to JukLee0ira/XDPoSChain that referenced this pull request May 21, 2024
@JukLee0ira
ethapi: implement eth_getBlockReceipts (ethereum#27702)
05d3b1a
JukLee0ira added a commit to JukLee0ira/XDPoSChain that referenced this pull request May 21, 2024
@JukLee0ira
ethapi: implement eth_getBlockReceipts (ethereum#27702)
9f477fa
JukLee0ira added a commit to JukLee0ira/XDPoSChain that referenced this pull request May 21, 2024
@JukLee0ira
ethapi: implement eth_getBlockReceipts (ethereum#27702)
c928c79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@s1na s1na s1na approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jsvisa @s1na @holiman @hitdavid @fjl