core/types: add derived chain ID to LegacyTx JSON encoding #27452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeman-jiang
requested review from
karalabe,
holiman and
rjl493456442
as code owners
lightclient
reviewed
Jun 11, 2023
lightclient
reviewed
Jun 12, 2023
|
Adding to triage. Main question I have is now legacy transactions don't check if the |
fjl
approved these changes
Jun 13, 2023
holiman
approved these changes
Jun 13, 2023
yperbasis
added a commit
to ledgerwatch/erigon
that referenced
this pull request
Jun 14, 2023
For legacy transactions ChainID is optional (missing in pre-[EIP155](https://eips.ethereum.org/EIPS/eip-155) transactions) and is derived from `V` anyway. Also, cherry pick ethereum/go-ethereum#27452.
antonydenyer
pushed a commit
to antonydenyer/go-ethereum
that referenced
this pull request
Jul 28, 2023
…27452) Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
MoonShiesty
pushed a commit
to MoonShiesty/go-ethereum
that referenced
this pull request
Aug 30, 2023
…27452) Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…27452) Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…thereum#27452)" This reverts commit 120956b.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…thereum#27452)" This reverts commit 120956b.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…thereum#27452)" This reverts commit 120956b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When marshalling a legacy type transaction to JSON, the chain ID field is always omitted, despite the fact that it can be derived using the signature values after EIP-155.
This change adds the chain ID to a legacy transaction's JSON encoding when it can be derived.
If the transaction is not signed or is pre EIP-155, the chain ID will be omitted.