Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: remove unused error return from Attach #27450

Merged
merged 1 commit into from Jun 14, 2023

Conversation

pengin7384
Copy link
Contributor

Delete the unused error from return parameters, because Attach() function no longer returns an error.

@pengin7384 pengin7384 requested a review from fjl as a code owner June 10, 2023 07:56
@holiman holiman changed the title node: Delete the unused error from return parameters of Node.Attach()… node: remove unused error return from Attach Jun 13, 2023
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@holiman holiman added this to the 1.12.1 milestone Jun 14, 2023
@holiman holiman merged commit acc2a2a into ethereum:master Jun 14, 2023
1 of 2 checks passed
antonydenyer pushed a commit to antonydenyer/go-ethereum that referenced this pull request Jul 28, 2023
node: Delete the unused error from return parameters of Node.Attach() func
MoonShiesty pushed a commit to MoonShiesty/go-ethereum that referenced this pull request Aug 30, 2023
node: Delete the unused error from return parameters of Node.Attach() func
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
node: Delete the unused error from return parameters of Node.Attach() func
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants