Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus, core, eth/downloader, params: 4844 chain validation #27382

Merged
merged 1 commit into from May 31, 2023

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented May 30, 2023

This PR implements validating the excessDataGa and dataGasUsed fields of Cancun headers according to the updated spec per ethereum/EIPs#7062.

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM
One check that is implicit is that usedGas < excessDataGas + params.MaxDataGasPerBlock. I've convinced myself that this check is not explicitly needed, but maybe I'm missing something

@karalabe
Copy link
Member Author

usedGas < params.MaxDataGasPerBlock already, so the added check would be a bit funky?

@karalabe karalabe merged commit 1f9b69b into ethereum:master May 31, 2023
2 checks passed
antonydenyer pushed a commit to antonydenyer/go-ethereum that referenced this pull request Jul 28, 2023
MoonShiesty pushed a commit to MoonShiesty/go-ethereum that referenced this pull request Aug 30, 2023
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants