eth,core: add api debug_getTrieFlushInterval #27303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
May 19, 2023
jsvisa
changed the title
There was a problem hiding this comment.
Looks okish to me. The feature itself is tiny enough.
But honestly I am not a big fan of it. I am not sure when the reference based
in-memory garbage collection will be deprecated. It's supposed to be
replaced by path-based anyway. Feel like we will remove this feature a few
months later.
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
jsvisa
force-pushed
the
eth-check-trie-interval
branch
from
f6e3abd
to
2709a71
Compare
|
@rjl493456442 Thank you for your honest suggestion and careful consideration. We now adjust the gc commit rate on our node based on the current CPU and memory usage, as well as the growth ratio of the disk. We hope to know the current commit rate before making any adjustments. And we can drop the two apis together after merging pbss. |
holiman
approved these changes
May 30, 2023
antonydenyer
pushed a commit
to antonydenyer/go-ethereum
that referenced
this pull request
Jul 28, 2023
* core,eth: add api debug_getTrieFlushInterval Signed-off-by: jsvisa <delweng@gmail.com> * eth/api_debug: comment of SetTrieFlushInterval Signed-off-by: jsvisa <delweng@gmail.com> * Apply suggestions from code review --------- Signed-off-by: jsvisa <delweng@gmail.com> Co-authored-by: Martin Holst Swende <martin@swende.se>
MoonShiesty
pushed a commit
to MoonShiesty/go-ethereum
that referenced
this pull request
Aug 30, 2023
* core,eth: add api debug_getTrieFlushInterval Signed-off-by: jsvisa <delweng@gmail.com> * eth/api_debug: comment of SetTrieFlushInterval Signed-off-by: jsvisa <delweng@gmail.com> * Apply suggestions from code review --------- Signed-off-by: jsvisa <delweng@gmail.com> Co-authored-by: Martin Holst Swende <martin@swende.se>
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
* core,eth: add api debug_getTrieFlushInterval Signed-off-by: jsvisa <delweng@gmail.com> * eth/api_debug: comment of SetTrieFlushInterval Signed-off-by: jsvisa <delweng@gmail.com> * Apply suggestions from code review --------- Signed-off-by: jsvisa <delweng@gmail.com> Co-authored-by: Martin Holst Swende <martin@swende.se>
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 6d231bb.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 6d231bb.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 6d231bb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.