Skip to content

Commit

Permalink
fixed #28 and other small node.js issues
Browse files Browse the repository at this point in the history
  • Loading branch information
debris committed Jan 16, 2015
1 parent 2c36d5f commit 0172939
Show file tree
Hide file tree
Showing 10 changed files with 39 additions and 60 deletions.
47 changes: 18 additions & 29 deletions dist/ethereum.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions dist/ethereum.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/ethereum.min.js

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions example/contract.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

<head>
<script type="text/javascript" src="js/es6-promise/promise.min.js"></script>
<script type="text/javascript" src="../node_modules/bignumber.js/bignumber.min.js"></script>
<script type="text/javascript" src="../dist/ethereum.js"></script>
<script type="text/javascript">

Expand Down
3 changes: 3 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
var web3 = require('./lib/web3');
var ProviderManager = require('./lib/providermanager');
web3.provider = new ProviderManager();
web3.filter = require('./lib/filter');
web3.providers.WebSocketProvider = require('./lib/websocket');
web3.providers.HttpRpcProvider = require('./lib/httprpc');
web3.providers.QtProvider = require('./lib/qt');
Expand Down
4 changes: 2 additions & 2 deletions lib/abi.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@

// TODO: is these line is supposed to be here?
if (process.env.NODE_ENV !== 'build') {
var web3 = require('./web3'); // jshint ignore:line
var BigNumber = require('bignumber.js'); // jshint ignore:line
}

var BigNumber = require('bignumber.js');
var web3 = require('./web3'); // jshint ignore:line

// TODO: make these be actually accurate instead of falling back onto JS's doubles.
var hexToDec = function (hex) {
Expand Down
6 changes: 1 addition & 5 deletions lib/contract.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,7 @@
* @date 2014
*/

// TODO: is these line is supposed to be here?
if (process.env.NODE_ENV !== 'build') {
var web3 = require('./web3'); // jshint ignore:line
}

var web3 = require('./web3'); // jshint ignore:line
var abi = require('./abi');

/// method signature length in bytes
Expand Down
5 changes: 1 addition & 4 deletions lib/filter.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,7 @@
* @date 2014
*/

// TODO: is these line is supposed to be here?
if (process.env.NODE_ENV !== 'build') {
var web3 = require('./web3'); // jshint ignore:line
}
var web3 = require('./web3'); // jshint ignore:line

/// should be used when we want to watch something
/// it's using inner polling mechanism and is notified about changes
Expand Down
4 changes: 1 addition & 3 deletions lib/providermanager.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@
*/

// TODO: is these line is supposed to be here?
if (process.env.NODE_ENV !== 'build') {
var web3 = require('./web3'); // jshint ignore:line
}
var web3 = require('./web3'); // jshint ignore:line

/**
* Provider manager object prototype
Expand Down
13 changes: 4 additions & 9 deletions lib/web3.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@
* @date 2014
*/

var Filter = require('./filter');
var ProviderManager = require('./providermanager');

/// Recursively resolves all promises in given object and replaces the resolved values with promises
/// @param any object/array/promise/anything else..
/// @returns (resolves) object with replaced promises with their result
Expand Down Expand Up @@ -319,7 +316,7 @@ var web3 = {
/// eth object prototype
eth: {
watch: function (params) {
return new Filter(params, ethWatch);
return new web3.filter(params, ethWatch);
}
},

Expand All @@ -329,7 +326,7 @@ var web3 = {
/// shh object prototype
shh: {
watch: function (params) {
return new Filter(params, shhWatch);
return new web3.filter(params, shhWatch);
}
},

Expand Down Expand Up @@ -387,8 +384,6 @@ var shhWatch = {

setupMethods(shhWatch, shhWatchMethods());

web3.provider = new ProviderManager();

web3.setProvider = function(provider) {
provider.onmessage = messageHandler;
web3.provider.set(provider);
Expand All @@ -411,5 +406,5 @@ function messageHandler(data) {
}
}

if (typeof(module) !== "undefined")
module.exports = web3;
module.exports = web3;

0 comments on commit 0172939

Please sign in to comment.