Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Update workflow actions to use Node.js 20 versions #527

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

spencer-tb
Copy link
Collaborator

@spencer-tb spencer-tb commented Apr 26, 2024

🗒️ Description

Almost all of our CI workflows show the following warning message or similar:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v4, actions/setup-python@v4, DavidAnson/markdownlint-cli2-action@v11. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ states these must be updated by "Spring 2024", as github will drop support for actions that are not using node js 20.

This PR updates the these actions to use there respective node js 20 versions.

Versions updated alongside there respectice node js 20 release notes or issue

For more precise details please see the related issue below.

🔗 Related Issues

Resolves #526.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@spencer-tb spencer-tb added scope:ci Scope: Continuous Integration type:chore Type: Chore labels Apr 26, 2024
@spencer-tb spencer-tb self-assigned this Apr 26, 2024
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@spencer-tb spencer-tb merged commit 4783e6e into ethereum:main Apr 29, 2024
5 checks passed
shemnon pushed a commit to shemnon/execution-spec-tests that referenced this pull request May 13, 2024
…um#527)

* chore(ci): Update workflow actions to use Node.js 20 versions.

* chore: Add changelog.
marioevz added a commit that referenced this pull request May 28, 2024
* new(test): add tests for EOF/EIP-663 DUPN SWAPN

* improve code generation

* chore(ci): Update workflow actions to use Node.js 20 versions (#527)

* chore(ci): Update workflow actions to use Node.js 20 versions.

* chore: Add changelog.

* Add --traces support to besu (#511)

Add support for adding traces to output when using Besu.

Signed-off-by: Danno Ferrin <danno@numisight.com>

* feat(fw): call `evmone-eofparse` on generated EOF fixtures in fill (#519)

Co-authored-by: Dimitry Kh <dimitry@ethereum.org>
Co-authored-by: danceratopz <danceratopz@gmail.com>

* docs(fix): small fix to tracing report in readme cf #511 (#539)

* fix EOF return stack tests

The tests were previously corrected against a bug in Besu,

Signed-off-by: Danno Ferrin <danno@numisight.com>

* EXCHANGE

Exercise exchange operation

Signed-off-by: Danno Ferrin <danno@numisight.com>

* speling

Signed-off-by: Danno Ferrin <danno@numisight.com>

* move

Signed-off-by: Danno Ferrin <danno@numisight.com>

* feat(fw): Add EXCHANGE encoder

* new(tests): EOF - EIP-663: Invalid container due to invalid exchange

---------

Signed-off-by: Danno Ferrin <danno@numisight.com>
Co-authored-by: Paweł Bylica <pawel@ethereum.org>
Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
Co-authored-by: Mario Vega <marioevz@gmail.com>
Co-authored-by: Dimitry Kh <dimitry@ethereum.org>
Co-authored-by: danceratopz <danceratopz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:ci Scope: Continuous Integration type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(ci): Update github actions to use Node.js 20 compatible versions
2 participants