tests/cancun/eip6780: add test cases which use revert #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
requested changes
Aug 31, 2023
jwasinger
force-pushed
the
eip6780-revert-tests
branch
from
f499142
to
c33abe6
Compare
Co-authored-by: Mario Vega <marioevz@gmail.com>
jwasinger
force-pushed
the
eip6780-revert-tests
branch
from
af450d7
to
c33abe6
Compare
|
@marioevz I have addressed your points above and I think this is ready for further review when you get the time. |
Thanks! I'll try to get it done today :) |
marioevz
approved these changes
Sep 7, 2023
marioevz
changed the title
spencer-tb
pushed a commit
to spencer-tb/execution-spec-tests
that referenced
this pull request
Sep 18, 2023
* introduce eip6780 tests which make use of revert * fixed another test * better comments for tests * format comments * try to appease the linter * try again * wip * make outer selfdestruct optional via parametrization * Update tests/cancun/eip6780_selfdestruct/test_selfdestruct_revert.py Co-authored-by: Mario Vega <marioevz@gmail.com> * check that selfdestructable address was created * wip * fix lint * fix lint * try fix lint again * try fix lint * fix typo * Add another variant of outer selfdestruct --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two test cases based on a go-ethereum implementation mistake that was caught in PR review:
given contract A which has methods to receive balance (a no-op) and selfdestruct, and was created in current tx.
Test the following call sequence in the same transaction:
Transfer value to A and call A.selfdestruct. Recurse into a new call which transfers value to A, calls A.selfdestruct, and reverts.
I have add two variants of this scenario: one test where
Ais pre-existing and another where it is created in the same transaction that the test occurs in.