Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update op-geth dependency to v1.101309.0-rc.2 #9935

Merged
merged 11 commits into from Apr 4, 2024

Conversation

roberto-bayardo
Copy link
Collaborator

@roberto-bayardo roberto-bayardo commented Mar 21, 2024

Description

Update optimism monorepo to work with op-geth updated to v1.101309.0-rc.2 (this contains commits from upstream geth v1.13.9).

@roberto-bayardo roberto-bayardo requested a review from a team as a code owner March 21, 2024 05:51
Copy link
Contributor

coderabbitai bot commented Mar 21, 2024

Walkthrough

Walkthrough

The update primarily focuses on enhancing the Ethereum blockchain interaction within a Go project by upgrading the go-ethereum dependency and shifting to a forked version for specific customizations. It also includes improvements across various components like deployment processes, error handling, and testing adjustments. Notably, it addresses dependency resolution issues, particularly with the iris package, by pinning a specific version to mitigate broken release impacts.

Changes

Files Change Summaries
go.mod, op-ufm/go.mod Updated go-ethereum to v1.13.9 and replaced with roberto-bayardo/op-geth.
go.sum, op-ufm/go.sum Updated to reflect changes in dependencies, removing old and adding new references.
op-chain-ops/deployer/deployer.go Enhanced backend creation and deployment process, including better error handling and refactoring.
.../genesis/layer_one_test.go,
.../layer_two_test.go,
.../state/state_test.go,
.../crossdomain/legacy_withdrawal_test.go,
op-proposer/proposer/abi_test.go
Added nolint:staticcheck to suppress static check warnings.
.../genesis/layer_two.go,
.../immutables/immutables.go
Added error context and backend cleanup.
.../genesis/setters.go Improved error messages in setupPredeploy.
op-e2e/actions/l2_engine.go Minor cleanup by removing a blank line.
op-e2e/actions/reorg_test.go Disabled execution of RestartOpGeth in tests.
op-service/pin.go Introduced functionality to pin dependencies, addressing broken release issues.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@roberto-bayardo roberto-bayardo changed the title Update geth DRAFT: Update geth Mar 21, 2024
@roberto-bayardo roberto-bayardo force-pushed the update-geth branch 5 times, most recently from 02ece83 to 45b6087 Compare March 21, 2024 16:45
op-ufm/go.sum Outdated Show resolved Hide resolved
@roberto-bayardo roberto-bayardo force-pushed the update-geth branch 2 times, most recently from ed2c995 to 36325bf Compare March 21, 2024 21:31
go.mod Outdated Show resolved Hide resolved
@roberto-bayardo roberto-bayardo requested a review from a team as a code owner April 3, 2024 22:25
@roberto-bayardo roberto-bayardo changed the title Update op-geth dependency to version with v1.13.9 merge Update op-geth dependency to v1.101309.0-rc.2 Apr 3, 2024
@protolambda
Copy link
Contributor

Enforcing shanghai/canyon for L2 simulated backend by default now, to work with the simulated backend which hardcodes an empty withdrawal list argument for block-building.

@protolambda
Copy link
Contributor

I hit an issue when fixing/testing op-upgrade. The simulator shouldn't use op-stack hardforks, and just use regular EVM, for op-upgrade tests and behavior to not break.

@protolambda protolambda added this pull request to the merge queue Apr 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 4, 2024
@protolambda protolambda added this pull request to the merge queue Apr 4, 2024
Merged via the queue into ethereum-optimism:develop with commit c9b3ecb Apr 4, 2024
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants