Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: Fix bootnodes port #9621

Merged
merged 1 commit into from
Feb 22, 2024
Merged

op-node: Fix bootnodes port #9621

merged 1 commit into from
Feb 22, 2024

Conversation

trianglesphere
Copy link
Contributor

Description

This removes the discport specifier because UDP and TCP are actually both exposed on 30305 for these bootnodes.

Tests

Tested locally.

@trianglesphere trianglesphere requested a review from a team as a code owner February 21, 2024 23:12
Copy link
Contributor

coderabbitai bot commented Feb 21, 2024

Walkthrough

Walkthrough

The overall change consists of updating the default port numbers for three enode URLs in the config.go file within the op-node/p2p directory. The port numbers have been changed from 0 to 30305, which likely aims to standardize or correct the port assignments for these bootnodes.

Changes

File Change Summary
op-node/p2p/config.go Updated DefaultBootnodes variable: port numbers changed from 0 to 30305 for three enode URLs.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9cdd367) 28.96% compared to head (c749788) 0.64%.
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #9621       +/-   ##
===========================================
- Coverage    28.96%   0.64%   -28.32%     
===========================================
  Files          161      88       -73     
  Lines         7046    2313     -4733     
  Branches      1287     541      -746     
===========================================
- Hits          2041      15     -2026     
+ Misses        4899    2298     -2601     
+ Partials       106       0      -106     
Flag Coverage Δ
cannon-go-tests ?
chain-mon-tests ?
common-ts-tests ?
contracts-bedrock-tests 0.64% <ø> (ø)
contracts-ts-tests ?
core-utils-tests ?
sdk-next-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 73 files with indirect coverage changes

@protolambda protolambda added this pull request to the merge queue Feb 22, 2024
Merged via the queue into develop with commit 3c79670 Feb 22, 2024
71 checks passed
@protolambda protolambda deleted the jg/fix_bootnodes_ports branch February 22, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants