Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update geth dependency to version w/ v1.13.11 upstream commits #10041

Merged

Conversation

roberto-bayardo
Copy link
Collaborator

@roberto-bayardo roberto-bayardo commented Apr 4, 2024

Description

updates the op-geth dependency to v1.101311.0-rc.1 which includes upstream geth commits up to v1.13.11. The main changes required from this upgrade were around using uint256 instead of big.Int in various places.

@roberto-bayardo roberto-bayardo changed the title merge work update geth dependency to version w/ v1.13.11 upstream commits Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.85%. Comparing base (35c0ad8) to head (0593166).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10041      +/-   ##
===========================================
+ Coverage    42.40%   42.85%   +0.45%     
===========================================
  Files           73       69       -4     
  Lines         4830     4690     -140     
  Branches       766      754      -12     
===========================================
- Hits          2048     2010      -38     
+ Misses        2676     2574     -102     
  Partials       106      106              
Flag Coverage Δ
cannon-go-tests 82.29% <100.00%> (ø)
chain-mon-tests ?
common-ts-tests 26.72% <ø> (ø)
contracts-ts-tests 12.25% <ø> (ø)
core-utils-tests 44.03% <ø> (ø)
sdk-tests 40.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cannon/mipsevm/evm.go 93.93% <100.00%> (ø)

... and 4 files with indirect coverage changes

@trianglesphere
Copy link
Contributor

@roberto-bayardo it looks like you also need some op-program updates for the new uint256 type

@roberto-bayardo
Copy link
Collaborator Author

roberto-bayardo commented Apr 4, 2024

@roberto-bayardo it looks like you also need some op-program updates for the new uint256 type

thanks, fixed. Also updated the tests to use the monorepo blob library instead of the crate-crypto one.

@trianglesphere trianglesphere marked this pull request as ready for review April 4, 2024 18:36
Copy link
Contributor

coderabbitai bot commented Apr 4, 2024

Walkthrough

The overarching change across the codebase involves replacing the usage of big.Int with uint256.Int from the github.com/holiman/uint256 package for handling large integers, particularly balances. This transition aims to improve precision, compatibility, and error handling in various operations related to state management, transactions, and cryptographic proofs. Additionally, there are enhancements in error handling during receipt retrieval and refinements in blob handling and hash computations.

Changes

Files Change Summary
op-chain-ops/cmd/op-simulate/main.go
op-chain-ops/genesis/setters.go
op-chain-ops/state/...
op-node/rollup/derive/fuzz_parsers_test.go
op-node/withdrawals/proof.go
op-program/client/l2/db_test.go
op-wheel/cheat/cheat.go
cannon/mipsevm/...
packages/contracts-bedrock/scripts/go-ffi/differential-testing.go
Transitioned from big.Int to uint256.Int for handling balances and large integers, improving precision and error handling.
op-chain-ops/genesis/layer_one.go Enhanced balance parsing error handling by switching from math.ParseBig256 to uint256.Int with UnmarshalText.
op-e2e/e2eutils/wait/waits.go Improved error handling during receipt retrieval by checking for additional error conditions.
op-program/host/prefetcher/...
op-service/eth/blob.go
Refactored blob handling and hash computations, utilizing updated methods and structures for better efficiency and accuracy.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving changes in contracts package

@trianglesphere trianglesphere added this pull request to the merge queue Apr 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 5, 2024
@trianglesphere trianglesphere added this pull request to the merge queue Apr 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 5, 2024
@trianglesphere trianglesphere added this pull request to the merge queue Apr 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 5, 2024
@trianglesphere trianglesphere added this pull request to the merge queue Apr 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 5, 2024
@trianglesphere trianglesphere added this pull request to the merge queue Apr 8, 2024
Merged via the queue into ethereum-optimism:develop with commit 75816d1 Apr 8, 2024
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants