Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image info stuff (ESPTOOL-675) #874

Merged
merged 2 commits into from Apr 25, 2023

Conversation

xyzzy42
Copy link
Contributor

@xyzzy42 xyzzy42 commented Apr 20, 2023

Description of change

Add some additional decoding for the image_info command.

I have tested this change with the following hardware & software combinations:

Linux. image_info doesn't interact with boards.

@github-actions github-actions bot changed the title Image info stuff Image info stuff (ESPTOOL-675) Apr 20, 2023
Copy link
Contributor

@peterdragun peterdragun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Overall the improvement seems good, I left some minor comments. After fixing those we are good to go.

Can you please also rebase the PR?

test/test_image_info.py Outdated Show resolved Hide resolved
esptool/cmds.py Outdated Show resolved Hide resolved
The image formats know about the special value 0xee used to disable WP.
Display this with image_info.

E.g.:

ESP32-C3 extended image header
==============================
WP pin: 0xee (disabled)
Example:

Flash pins drive settings: clk_drv: 0x0, q_drv: 0x0, d_drv: 0x0, cs0_drv: 0x0, hd_drv: 0x0, wp_drv: 0x0
Chip ID: 5 (ESP32-C3)
Minimal chip revision: v0.0, (legacy min_rev = 0)
Maximal chip revision: v655.35

An unknown ID will be printed as:

Chip ID: 42 (Unknown ID)
@xyzzy42
Copy link
Contributor Author

xyzzy42 commented Apr 24, 2023

Can you please also rebase the PR?

It's based off of latest master of this repo. Is there something else to use? I don't see a dev branch.

@peterdragun
Copy link
Contributor

You are right, it is okay. Sorry, I somehow overlooked the latest commit and thought you are missing it.

@espressif-bot espressif-bot merged commit 0df000c into espressif:master Apr 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants