Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing backticks to func-style #19227

Merged

Conversation

lumirlumir
Copy link
Contributor

@lumirlumir lumirlumir commented Dec 7, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Hello,

I've added missing backticks to func-style.md.

While undefined is a code-related value, it was not marked with backticks (inline code block), so I added them.

Is there anything you'd like reviewers to focus on?

Sorry, something went wrong.

@lumirlumir lumirlumir requested a review from a team as a code owner December 7, 2024 04:35
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Dec 7, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

netlify bot commented Dec 7, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 983919c
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/675449fe19e8160008204fc4
😎 Deploy Preview https://deploy-preview-19227--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit bf2a4f6 into eslint:main Dec 7, 2024
29 of 30 checks passed
@lumirlumir lumirlumir deleted the docs-add-missing-backticks-to-func-style branch December 7, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants