Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Rule Tester checks for missing placeholder data in the message #18073

Merged
merged 16 commits into from
Feb 9, 2024
Merged

feat!: Rule Tester checks for missing placeholder data in the message #18073

merged 16 commits into from
Feb 9, 2024

Commits on Feb 9, 2024

  1. feat!: rule tester checks for missing placeholder data for the report… 

    …ed message
    @DMartens
    DMartens committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    5895060 View commit details
    Browse the repository at this point in the history

  2. chore: incorporate bmishs suggestions

    @DMartens
    DMartens committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    c881a45 View commit details
    Browse the repository at this point in the history

  3. chore: differentiate message between a single and multiple missing da… 

    …ta properties
    @DMartens
    DMartens committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    d354d58 View commit details
    Browse the repository at this point in the history

  4. fix: check for missing placeholders with data specified

    @DMartens
    DMartens committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    a10b636 View commit details
    Browse the repository at this point in the history

  5. feat: share regular expression for message placeholders

    @DMartens
    DMartens committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    494317e View commit details
    Browse the repository at this point in the history

  6. feat: ignore introduced message placeholders

    @DMartens
    DMartens committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    a39edf7 View commit details
    Browse the repository at this point in the history

  7. refactor: simplified logic for getting unsubstituted message placehol… 

    …ders
    @DMartens
    DMartens committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    e1b49fc View commit details
    Browse the repository at this point in the history

  8. docs: also use term unsubstituted for migration guide 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @DMartens @mdjermanovic
    DMartens and mdjermanovic committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    5ee4d25 View commit details
    Browse the repository at this point in the history

  9. docs: clarify placeholder versus data 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @DMartens @mdjermanovic
    DMartens and mdjermanovic committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    22ee891 View commit details
    Browse the repository at this point in the history

  10. chore: message grammar fixes 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @DMartens @mdjermanovic
    DMartens and mdjermanovic committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    600da81 View commit details
    Browse the repository at this point in the history

  11. chore: update error messages for the grammar fixes

    @DMartens
    DMartens committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    c636cdd View commit details
    Browse the repository at this point in the history

  12. fix: remove unnecessary check for added placeholders

    @DMartens
    DMartens committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    9e4030c View commit details
    Browse the repository at this point in the history

  13. chore: split up object to avoid referencing the placeholder matcher v… 

    …ia module.exports
    @DMartens
    DMartens committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    5483b37 View commit details
    Browse the repository at this point in the history

  14. chore: add mention of the issue for the migration guide

    @DMartens
    DMartens committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    b7a82af View commit details
    Browse the repository at this point in the history

  15. chore: stylize rule tester in migration guide

    @DMartens
    DMartens committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    1305386 View commit details
    Browse the repository at this point in the history

  16. chore: clarify message for unsubstituted placeholders and introduce 

    fixture for non-string data values
    @DMartens
    DMartens committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    371fa25 View commit details
    Browse the repository at this point in the history