Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle absolute file paths in FlatRuleTester #18064

Merged
merged 1 commit into from
Feb 1, 2024
Merged

fix: handle absolute file paths in FlatRuleTester #18064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/rule-tester/flat-rule-tester.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
const
assert = require("assert"),
util = require("util"),
path = require("path"),
equal = require("fast-deep-equal"),
Traverser = require("../shared/traverser"),
{ getRuleOptionsSchema } = require("../config/flat-config-helpers"),
Expand Down Expand Up @@ -592,7 +593,15 @@ class FlatRuleTester {
* @private
*/
function runRuleForItem(item) {
const configs = new FlatConfigArray(testerConfig, { baseConfig });
const flatConfigArrayOptions = {
baseConfig
};

if (item.filename) {
flatConfigArrayOptions.basePath = path.parse(item.filename).root;
}

const configs = new FlatConfigArray(testerConfig, flatConfigArrayOptions);

/*
* Modify the returned config so that the parser is wrapped to catch
Expand Down
16 changes: 16 additions & 0 deletions tests/lib/rule-tester/flat-rule-tester.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1808,6 +1808,22 @@ describe("FlatRuleTester", () => {
}, /Fixable rules must set the `meta\.fixable` property/u);
});

// https://github.com/eslint/eslint/issues/17962
it("should not throw an error in case of absolute paths", () => {
ruleTester.run("no-eval", require("../../fixtures/testers/rule-tester/no-eval"), {
valid: [
"Eval(foo)"
],
invalid: [
{
code: "eval(foo)",
filename: "/an-absolute-path/foo.js",
errors: [{ message: "eval sucks.", type: "CallExpression" }]
}
]
});
});

describe("suggestions", () => {
it("should pass with valid suggestions (tested using desc)", () => {
ruleTester.run("suggestions-basic", require("../../fixtures/testers/rule-tester/suggestions").basic, {
Expand Down