Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependency markdownlint to ^0.31.0 #17732

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 8, 2023

Mend Renovate logo banner

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
markdownlint ^0.25.1 -> ^0.31.0 age adoption passing confidence

Release Notes

DavidAnson/markdownlint (markdownlint)

v0.31.1

Compare Source

  • Improve MD032/MD034
  • Update dependencies

v0.31.0

Compare Source

  • Improve MD032/MD037/MD043/MD044/MD051/MD052
  • Improve performance
  • Update dependencies

v0.30.0

Compare Source

  • Use micromark in MD022/MD026/MD032/MD037/MD045/MD051
  • Incorporate micromark-extension-math for math syntax
  • Allow custom rules to override information URL
  • Update dependencies

v0.29.0

Compare Source

  • Update micromark parser dependencies for better performance
  • Use micromark in MD049/MD050
  • Improve MD034/MD037/MD044/MD049/MD050
  • Support multiple parsers in demo page
  • Remove support for end-of-life Node version 14
  • Update dependencies

v0.28.2

Compare Source

v0.28.1

Compare Source

  • Update dependencies

v0.28.0

Compare Source

  • Introduce micromark parser for better positional data (internal only)
  • Use micromark in MD013/MD033/MD034/MD035/MD038/MD044/MD052/MD053
  • Simplify file-based test cases
  • Unify browser script for demo page
  • Update dependencies

v0.27.0

Compare Source

  • Improve MD011/MD013/MD022/MD031/MD032/MD033/MD034/MD040/MD043/MD051/MD053
  • Generate/separate documentation
  • Improve documentation
  • Update dependencies

v0.26.2

Compare Source

  • Improve MD037/MD051/MD053

v0.26.1

Compare Source

  • Improve MD051

v0.26.0

Compare Source

  • Add MD051/MD052/MD053 for validating link fragments & reference
    links/images & link/image reference definitions (MD053 auto-fixable)
  • Improve MD010/MD031/MD035/MD039/MD042/MD044/MD049/MD050
  • Add markdownlint-disable-line inline comment
  • Support ~ paths in readConfig/Sync
  • Add configParsers option
  • Remove support for end-of-life Node version 12
  • Default resultVersion to 3
  • Update browser script to use ES2015
  • Simplify JSON schema
  • Address remaining CodeQL issues
  • Improve performance
  • Update dependencies

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner November 8, 2023 19:40
@renovate renovate bot added dependencies Pull requests that update a dependency file deps:npm labels Nov 8, 2023
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Nov 8, 2023
Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 1d08df9
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/654d019862e345000865e8c3

@renovate renovate bot force-pushed the renovate/markdownlint-0.x branch from 0951570 to 1d08df9 Compare November 9, 2023 15:58
nzakas
nzakas previously approved these changes Nov 9, 2023
@snitin315
Copy link
Contributor

markdown-lint can't be upgraded to the latest version right now as it requires node >=18. This project doesn't seem to follow semantic versioning.

Should we close the PR?

@mdjermanovic
Copy link
Member

mdjermanovic commented Nov 15, 2023

markdown-lint can't be upgraded to the latest version right now as it requires node >=18. This project doesn't seem to follow semantic versioning.

I believe the semver rules are different for major version zero - anything can change in any version, though it's common practice that breaking changes bump the minor version, which is the case here.

Should we close the PR?

We already have some dev dependencies that require a higher version of Node.js than ESLint, and requirements for the development environment don't necessarily need to be the same as for the released package, so I think we could update markdownlint. The problem here is that in Makefile.js we require() most dependencies at the top, so when we run node Makefile mocha it loads markdownlint although this operation doesn't use it, and markdownlint happens to crash right away while loading on older versions of Node.js. I believe the problem can be solved by moving require("markdownlint") into function lintMarkdown. The question is whether it is worth the effort at this point, though it might be good to reduce Makefile's loading time anyway.

@snitin315
Copy link
Contributor

@mdjermanovic Yes, you're right. Upgraded it in #17754

@mdjermanovic mdjermanovic deleted the renovate/markdownlint-0.x branch November 16, 2023 08:28
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators May 15, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing dependencies Pull requests that update a dependency file deps:npm
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

3 participants