feat!: Remove deprecated context methods #17698

nzakas · 2023-10-31T16:11:31Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Removed the deprecated methods on the context object.

fixes #17520

Is there anything you'd like reviewers to focus on?

netlify · 2023-10-31T16:11:37Z

✅ Deploy Preview for docs-eslint ready!

Name	Link
🔨 Latest commit	`ffb5d0a`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/657b2df96955f300081fe380
😎 Deploy Preview	https://deploy-preview-17698--docs-eslint.netlify.app/extend/custom-rules
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdjermanovic · 2023-11-04T21:31:32Z

lib/linter/linter.js

-        {}
-    )
-);
+const BASE_TRAVERSAL_CONTEXT = {};


Do we still need BASE_TRAVERSAL_CONTEXT? Looks like we can just remove it now.

Ah, right you are!

mdjermanovic · 2023-11-04T22:50:09Z

We should also remove deprecation warnings from the RuleTester:

eslint/lib/rule-tester/rule-tester.js

Lines 175 to 195 in 5454c22

    
           getSource: "getText", 
        
           getSourceLines: "getLines", 
        
           getAllComments: "getAllComments", 
        
           getNodeByRangeIndex: "getNodeByRangeIndex", 
        
           // getComments: "getComments", -- already handled by a separate error 
        
           getCommentsBefore: "getCommentsBefore", 
        
           getCommentsAfter: "getCommentsAfter", 
        
           getCommentsInside: "getCommentsInside", 
        
           getJSDocComment: "getJSDocComment", 
        
           getFirstToken: "getFirstToken", 
        
           getFirstTokens: "getFirstTokens", 
        
           getLastToken: "getLastToken", 
        
           getLastTokens: "getLastTokens", 
        
           getTokenAfter: "getTokenAfter", 
        
           getTokenBefore: "getTokenBefore", 
        
           getTokenByRangeStart: "getTokenByRangeStart", 
        
           getTokens: "getTokens", 
        
           getTokensAfter: "getTokensAfter", 
        
           getTokensBefore: "getTokensBefore", 
        
           getTokensBetween: "getTokensBetween",

nzakas · 2023-11-06T16:59:42Z

Oops, yes. Removed from the tests but not RuleTester itself. Good catch.

github-actions · 2023-11-16T22:31:25Z

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

mdjermanovic · 2023-11-20T11:31:37Z

tests/lib/linter/linter.js

-
-            });
-
-            describe("context.getAncestors()", () => {


Tests for context.getAncestors() shouldn't be removed in this PR?

It looks like getAncestors(), getScope(), getDeclaredVariables(), and markVariableAsUsed() don't actually have a separate issue tracking their removal, despite us announcing it.

So maybe I should remove those in this PR too?

It's a subtask of #16999 (Phase 8: Removal of old APIs; just it seems that markVariableAsUsed() was accidentally omitted from that list, and note that the list includes removing context.parserServices as well) which is tracked in the v9 project.

Regardless, seems best and easiest for maintaining the alpha release to remove them as well in this PR 👍

Ah good call, those subtasks are tricky to remember. I've updated the list to reflect reality and will add the rest into this PR.

nzakas · 2023-11-22T16:56:03Z

Note: Linting is failed because eslint-plugin-n is still using the old getScope() and getAncestors(), which have been removed. I opened an issue here:
eslint-community/eslint-plugin-n#143

github-actions · 2023-12-02T22:31:19Z

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

github-actions · 2023-12-10T22:31:18Z

This pull request was auto-closed due to inactivity. While we wish we could keep working on every request, we unfortunately don't have the bandwidth to continue here and need to focus on other things. You can resubmit this pull request if you would like to continue working on it.

aladdin-add · 2023-12-11T07:06:11Z

I've made a few updates, hopefully it can fix the lint failing:

mdjermanovic · 2023-12-11T11:21:53Z

I've made a few updates, hopefully it can fix the lint failing:

chore: update eslint-plugin-n v16.4.0 #17836

chore: upgrade eslint-plugin-unicorn to v49.0.0 #17837

chore: upgrade eslint-plugin-eslint-plugin v5.2.1 #17838

All merged now. I checked this branch locally and linting works now. There are just several lint errors and a merge conflict in package.json that should be fixed.

fixes #17520

nzakas · 2023-12-11T15:56:30Z

Fixed merge conflicts and re-pushed the branch.

aladdin-add · 2023-12-12T00:58:28Z

seems there are a few linting errors that need to be fixed.

nzakas · 2023-12-12T16:54:01Z

Thanks. Fixed!

docs/src/extend/custom-rules.md

Co-authored-by: 唯然 <weiran.zsd@outlook.com>

docs/src/extend/custom-rules.md

mdjermanovic · 2023-12-14T11:16:11Z

tests/lib/linter/linter.js

            assert.strictEqual(suppressedMessages.length, 0);
        });

-        it("should expose parser services when using parseForESLint() and services are specified", () => {


I think we should keep tests with parserServices as they're testing how Linter creates SourceCode objects based on parser features. We could just remove the assert.strictEqual(context.parserServices, context.sourceCode.parserServices) line.

mdjermanovic · 2023-12-14T11:20:57Z

tests/lib/linter/linter.js

            assert.strictEqual(suppressedMessages.length, 0);
        });

-        it("should use the same parserServices if source code object is reused", () => {


Same as the previous comment, I think we should keep this test here.

mdjermanovic · 2023-12-14T11:21:42Z

tests/lib/linter/linter.js


-                it("should expose parser services when using parseForESLint() and services are specified", () => {


Same as the previous comment, I think we should keep this test here.

mdjermanovic · 2023-12-14T11:22:09Z

tests/lib/linter/linter.js


-                it("should use the same parserServices if source code object is reused", () => {


Same as the previous comment, I think we should keep this test here.

mdjermanovic · 2023-12-14T11:59:10Z

tests/lib/linter/linter.js

Just a tip if anyone else is going to review this: better use VS Code diff viewer for this file, as this diff here is pretty much unusable and the diff is not as large as it appears to be.

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

nzakas · 2023-12-14T16:35:14Z

Also updated eslint-plugin-n so linting will no longer fail. 🎉

mdjermanovic

LGTM, thanks!

mdjermanovic · 2023-12-19T08:31:24Z

tests/lib/linter/linter.js


-    describe("when calling context.getScope", () => {


I just noticed that this set of tests wasn't copied into source-code tests, but we could do that in another PR.

mdjermanovic · 2023-12-19T08:46:15Z

tests/lib/linter/linter.js

-        });
-    });
-
-    describe("Variables and references", () => {


This set of tests also doesn't exist in source-code tests, though these look more like tests for eslint-scope than tests for linter.

* main: (25 commits) test: ensure that CLI tests run with FlatESLint (eslint#17884) fix!: Behavior of CLI when no arguments are passed (eslint#17644) docs: Update README Revert "feat!: Remove CodePath#currentSegments" (eslint#17890) feat!: Update shouldUseFlatConfig and CLI so flat config is default (eslint#17748) feat!: Remove CodePath#currentSegments (eslint#17756) chore: update dependency markdownlint-cli to ^0.38.0 (eslint#17865) feat!: deprecate no-new-symbol, recommend no-new-native-nonconstructor (eslint#17710) feat!: check for parsing errors in suggestion fixes (eslint#16639) feat!: assert suggestion messages are unique in rule testers (eslint#17532) feat!: `no-invalid-regexp` make allowConstructorFlags case-sensitive (eslint#17533) fix!: no-sequences rule schema correction (eslint#17878) feat!: Update `eslint:recommended` configuration (eslint#17716) feat!: drop support for string configurations in flat config array (eslint#17717) feat!: Remove `SourceCode#getComments()` (eslint#17715) feat!: Remove deprecated context methods (eslint#17698) feat!: Swap FlatESLint-ESLint, FlatRuleTester-RuleTester in API (eslint#17823) feat!: remove formatters except html, json(-with-metadata), and stylish (eslint#17531) feat!: Require Node.js `^18.18.0 || ^20.9.0 || >=21.1.0` (eslint#17725) fix: allow circular references in config (eslint#17752) ...

eslint-github-bot bot added breaking This change is backwards-incompatible feature This change adds a new feature to ESLint labels Oct 31, 2023

mdjermanovic added core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion labels Nov 4, 2023

mdjermanovic reviewed Nov 4, 2023

View reviewed changes

github-actions bot added the Stale label Nov 16, 2023

Rec0iL99 removed the Stale label Nov 17, 2023

mdjermanovic reviewed Nov 20, 2023

View reviewed changes

nzakas mentioned this pull request Nov 22, 2023

Bug: Update context methods to source code methods eslint-community/eslint-plugin-n#143

Closed

1 task

github-actions bot added the Stale label Dec 2, 2023

bmish mentioned this pull request Dec 3, 2023

Catch additional deprecated methods in no-deprecated-context-methods rule eslint-community/eslint-plugin-eslint-plugin#398

Open

nzakas mentioned this pull request Dec 5, 2023

docs: Add 2023-11-30 meeting notes eslint/tsc-meetings#472

Merged

github-actions bot closed this Dec 10, 2023

aladdin-add reopened this Dec 11, 2023

mdjermanovic removed the Stale label Dec 11, 2023

nzakas added 5 commits December 11, 2023 10:54

feat!: Remove deprecated context methods

6919a16

fixes #17520

Fix broken tests

767c539

Remove BASE_TRAVERSAL_CONTEXT

5f07de1

Remove deprecated methods from RuleTester

ec2272d

Removed more methods/properties

3ecac71

nzakas force-pushed the issue17520-2 branch from 904b1ea to 3ecac71 Compare December 11, 2023 15:56

Fix lint errors

b16e62c

aladdin-add reviewed Dec 13, 2023

View reviewed changes

docs/src/extend/custom-rules.md Outdated Show resolved Hide resolved

Update docs/src/extend/custom-rules.md

c89855a

Co-authored-by: 唯然 <weiran.zsd@outlook.com>

mdjermanovic reviewed Dec 14, 2023

View reviewed changes

docs/src/extend/custom-rules.md Outdated Show resolved Hide resolved

docs/src/extend/custom-rules.md Outdated Show resolved Hide resolved

docs/src/extend/custom-rules.md Outdated Show resolved Hide resolved

mdjermanovic reviewed Dec 14, 2023

View reviewed changes

nzakas and others added 5 commits December 14, 2023 10:51

Update docs/src/extend/custom-rules.md

6b09d19

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

Update docs/src/extend/custom-rules.md

3b110ac

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

Update docs/src/extend/custom-rules.md

f33b0a2

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

Remove unneeded deprecated notices

8ba1ae2

Restore parserServices tests

ffb5d0a

mdjermanovic approved these changes Dec 19, 2023

View reviewed changes

mdjermanovic marked this pull request as ready for review December 20, 2023 13:41

mdjermanovic requested a review from a team as a code owner December 20, 2023 13:41

mdjermanovic merged commit ae78ff1 into main Dec 20, 2023
22 checks passed

mdjermanovic deleted the issue17520-2 branch December 20, 2023 13:45

felipeqq2 mentioned this pull request Apr 6, 2024

Upgrade to eslint v9 avajs/eslint-plugin-ava#356

Closed

rwlxxvii mentioned this pull request May 17, 2024

[Snyk] Upgrade eslint from 9.0.0 to 9.1.1 rwlxxvii/containers#114

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: Remove deprecated context methods #17698

feat!: Remove deprecated context methods #17698

nzakas commented Oct 31, 2023

netlify bot commented Oct 31, 2023 •

edited

mdjermanovic Nov 4, 2023

nzakas Nov 6, 2023

mdjermanovic commented Nov 4, 2023

nzakas commented Nov 6, 2023

github-actions bot commented Nov 16, 2023

mdjermanovic Nov 20, 2023

nzakas Nov 20, 2023

mdjermanovic Nov 20, 2023

nzakas Nov 21, 2023

nzakas commented Nov 22, 2023

github-actions bot commented Dec 2, 2023

github-actions bot commented Dec 10, 2023

aladdin-add commented Dec 11, 2023 •

edited

mdjermanovic commented Dec 11, 2023

nzakas commented Dec 11, 2023

aladdin-add commented Dec 12, 2023

nzakas commented Dec 12, 2023

mdjermanovic Dec 14, 2023

mdjermanovic Dec 14, 2023

mdjermanovic Dec 14, 2023

mdjermanovic Dec 14, 2023

mdjermanovic Dec 14, 2023

nzakas commented Dec 14, 2023

mdjermanovic left a comment

mdjermanovic Dec 19, 2023

mdjermanovic Dec 19, 2023


		it("should expose parser services when using parseForESLint() and services are specified", () => {


		it("should use the same parserServices if source code object is reused", () => {

feat!: Remove deprecated context methods #17698

feat!: Remove deprecated context methods #17698

Conversation

nzakas commented Oct 31, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

netlify bot commented Oct 31, 2023 • edited

✅ Deploy Preview for docs-eslint ready!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mdjermanovic commented Nov 4, 2023

nzakas commented Nov 6, 2023

github-actions bot commented Nov 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nzakas commented Nov 22, 2023

github-actions bot commented Dec 2, 2023

github-actions bot commented Dec 10, 2023

aladdin-add commented Dec 11, 2023 • edited

mdjermanovic commented Dec 11, 2023

nzakas commented Dec 11, 2023

aladdin-add commented Dec 12, 2023

nzakas commented Dec 12, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nzakas commented Dec 14, 2023

mdjermanovic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

netlify bot commented Oct 31, 2023 •

edited

aladdin-add commented Dec 11, 2023 •

edited