Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure shared references in rule configs are separated. #17666

Merged
merged 6 commits into from
Oct 20, 2023
Merged

fix: Ensure shared references in rule configs are separated. #17666

merged 6 commits into from
Oct 20, 2023

Commits on Oct 19, 2023

  1. fix: Ensure shared references in rule configs are separated. 

    In eslint.config.js files, it's possible for two rule configs to contain
references to the same object. That object may be modified during
validation, thus affecting all configs, and may create validation
errors. This clones rule configs before validation to ensure that each
rule is using unique references to manage its configs.

Fixes #12592
    @nzakas
    nzakas committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    faadfb3 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Update tests/lib/config/flat-config-array.js 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @nzakas @mdjermanovic
    nzakas and mdjermanovic committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    7f825ba View commit details
    Browse the repository at this point in the history

  2. Update tests/lib/config/flat-config-array.js 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @nzakas @mdjermanovic
    nzakas and mdjermanovic committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    20a9937 View commit details
    Browse the repository at this point in the history

  3. Update lib/config/flat-config-schema.js 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @nzakas @mdjermanovic
    nzakas and mdjermanovic committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    3575bee View commit details
    Browse the repository at this point in the history

  4. Update lib/config/flat-config-schema.js 

    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    @nzakas @mdjermanovic
    nzakas and mdjermanovic committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    b8cb9b6 View commit details
    Browse the repository at this point in the history

  5. Upgrade config-array and update tests

    @nzakas
    nzakas committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    ffd3789 View commit details
    Browse the repository at this point in the history