New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add findConfigFile() method to FlatESLint #17142
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I'll leave this open for a couple of days in case anyone else wants to take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nzakas in the default mode ( |
Fixed by #17151. |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Adds a
findConfigFile()
method toFlatESLint
. The purpose of this method is to return the location of the config file thisFlatESLint
instance will use as the basis for its configuration without actually loading the file.Fixes #17046
Is there anything you'd like reviewers to focus on?
I didn't include any caching for the config file path as I don't see this as a common enough use case to optimize what is typically a very fast search. Let me know if you think differently.