Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: stricter validation of rule tests #15376

Closed
wants to merge 1 commit into from
Closed

Conversation

bmish
Copy link
Sponsor Member

@bmish bmish commented Dec 1, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[X] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Adds rule test assertions per eslint/rfcs#84
Fixes #15104

This demonstrates the changes needed for this RFC.

TODO:

  • Wait for RFC approval
  • Wait for ESLint v9
  • Add tests

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Dec 1, 2021
@eslint-github-bot
Copy link

Hi @bmish!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

@eslint-github-bot eslint-github-bot bot added breaking This change is backwards-incompatible feature This change adds a new feature to ESLint labels Dec 1, 2021
@bmish bmish changed the title breaking: stricter validation of rule tests feat!: stricter validation of rule tests Dec 1, 2021
@bmish bmish marked this pull request as draft December 1, 2021 03:29
@nzakas
Copy link
Member

nzakas commented Dec 3, 2021

@bmish given that v9 is pretty far away, would you mind if we closed this PR? You can obviously continue to work on the branch, but right now it’s just noise in the list of PRs. You can always reopen when we are closer to v9

@bmish
Copy link
Sponsor Member Author

bmish commented Dec 3, 2021

@nzakas yep totally fine.

@bmish bmish closed this Dec 3, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jun 2, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible feature This change adds a new feature to ESLint triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Request: Stricter rule test validation
2 participants