docs: Update PR review process #18233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
amareshsm
reviewed
Mar 26, 2024
amareshsm
reviewed
Mar 26, 2024
amareshsm
reviewed
Mar 26, 2024
amareshsm
added
the
accepted
Co-authored-by: Amaresh S M <amareshsm13@gmail.com>
Co-authored-by: Amaresh S M <amareshsm13@gmail.com>
Co-authored-by: Amaresh S M <amareshsm13@gmail.com>
mdjermanovic
previously approved these changes
Mar 26, 2024
amareshsm
previously approved these changes
Mar 28, 2024
fasttime
previously approved these changes
Mar 28, 2024
aladdin-add
reviewed
Mar 28, 2024
|
|
||
| If the pull request does not have a related issue, then it should be moved through the normal [triage process for issues](./manage-issues) to be marked as accepted. Once accepted, move the pull request to the "Implementing" column. | ||
|
|
||
| If the pull request does have a related issue, then move the pull request to the "Implementing" column. |
There was a problem hiding this comment.
Normally I moved to "Implementing" only if the corresponding issue has been accepted, otherwise I moved to "evaluating". This needs to change?
There was a problem hiding this comment.
That's a good point. @mdjermanovic @fasttime what do you think?
There was a problem hiding this comment.
I agree, "evaluating" makes more sense than "implementing" when the corresponding issue hasn't been accepted yet.
nzakas
dismissed stale reviews from fasttime, amareshsm, Tanujkanti4441, and mdjermanovic
via
07ede6e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Updated the pull request review process to better reflect what we actually do and include how to use the two new columns in the triage board.
Is there anything you'd like reviewers to focus on?
Does this process make sense?