Skip to content

Commit

Permalink
Merge branch 'triage-updates' of github.com:eslint/eslint into triage…
Browse files Browse the repository at this point in the history
…-updates
  • Loading branch information
nzakas committed Mar 29, 2024
2 parents 939e0a0 + d665d7d commit 07ede6e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions docs/src/maintain/review-pull-requests.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Once the bot checks have been satisfied, you check the following:

## Required Approvals for Pull Requests

Any committer, reviewer, or TSC members may approve a pull request, but the approvals required for merging differ based on the type of pull request.
Any committer, reviewer, or TSC member may approve a pull request, but the approvals required for merging differ based on the type of pull request.

One committer approval is required to merge a non-breaking change that is:

Expand All @@ -49,7 +49,7 @@ One committer approval is required to merge a non-breaking change that is:
1. Related to the build
1. A chore

For a non-breaking feature, pull requests require an approval from one reviewer or TSC member, plus one additional approval from any other team member.
For a non-breaking feature, pull requests require approval from one reviewer or TSC member, plus one additional approval from any other team member.

For a breaking change, pull requests require an approval from two TSC members.

Expand Down Expand Up @@ -110,7 +110,7 @@ Otherwise, team members should observe a waiting period before merging a pull re

The waiting period ensures that other team members have a chance to review the pull request before it is merged.

**Note:** You should not merge your own pull request unless you're received the required approvals.
**Note:** You should not merge your pull request unless you receive the required approvals.

## When to Close a Pull Request

Expand Down

0 comments on commit 07ede6e

Please sign in to comment.