docs: Switch to Ethical Ads #18090
docs: Switch to Ethical Ads #18090
Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
harish-sethuraman
changed the title
| @@ -4,6 +4,15 @@ | |||
| } | |||
| } | |||
|
|
|||
| .docs-ad { | |||
There was a problem hiding this comment.
we had a wrapper in the main page to avoid shift of content when ad pops up. Seems like docs didn't have it so added this.
|
We are ready to roll this out pending the removal of the unnecessary comments. |
|
Once merged, we should also merge this: eslint/eslint.org#522 |
mdjermanovic
added
the
accepted
There was a problem hiding this comment.
LGTM, thanks!
I'm leaving this open if @nzakas wants to take another look before merging, and because ideally this should be merged just before we start today's release so that the docs sites are updated around the same time (eslint.org/docs/head right before and eslint.org/docs/next right after the release).
What about eslint.org/docs/latest? Looks like we should prepare another PR that should target the latest branch?
|
There was a problem hiding this comment.
LGTM. I'll let @mdjermanovic merge just before the release.
|
Since we've already merged #18102 and the new ads are live on |
|
Oops, yes. :) |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
nope