feat: Switch to Ethical Ads #522
Conversation
✅ Deploy Preview for new-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Have duplicated the same in eslint repo eslint/eslint#18090 |
| serve: CESDV2QM | ||
| placement: eslintorg |
There was a problem hiding this comment.
should we consider doing the same here? keep serve and placement?
src/assets/scss/components/ads.scss
Outdated
|
|
||
| // [data-ea-publisher].loaded .ea-content a:hover, | ||
| // [data-ea-type].loaded .ea-content a:hover { | ||
| // text-decoration: none; | ||
| // color: var(--link-color); | ||
| // } |
There was a problem hiding this comment.
| // [data-ea-publisher].loaded .ea-content a:hover, | |
| // [data-ea-type].loaded .ea-content a:hover { | |
| // text-decoration: none; | |
| // color: var(--link-color); | |
| // } |
similar to the other PR
|
This switches ads on eslint.org only. Shall we do the same for translation sites (e.g., es.eslint.org) as well? |
|
@mdjermanovic yes, just needed to verify that it was okay to put the ads there, and it is. |
Prerequisites checklist
What is the purpose of this pull request?
Switches our ad to Ethical Ads from Carbon Ads.
What changes did you make? (Give an overview)
Migrated the site code to use Ethical Ads. Due to #520, this change is only visible on the homepage but will be visible on all pages once that is fixed.
We'll also need to duplicate this on the docs site.
Related Issues
Is there anything you'd like reviewers to focus on?