chore: disable jsdoc/no-defaults & jsdoc/check-line-alignment

the jsdoc/no-defaults rule is not compatible with the way we use JSDoc comments.
eslint · Jun 20, 2023 · 376dac4 · 376dac4
1 parent ea4575c
commit 376dac4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/lib/rule-tester/flat-rule-tester.js b/lib/rule-tester/flat-rule-tester.js
@@ -33,7 +33,7 @@ const { ConfigArraySymbol } = require("@humanwhocodes/config-array");
 /** @typedef {import("../shared/types").Parser} Parser */
 /** @typedef {import("../shared/types").LanguageOptions} LanguageOptions */
 
-/* eslint-disable jsdoc/valid-types -- https://github.com/jsdoc-type-pratt-parser/jsdoc-type-pratt-parser/issues/4#issuecomment-778805577 */
+
 /**
  * A test case that is expected to pass lint.
  * @typedef {Object} ValidTestCase
@@ -72,7 +72,6 @@ const { ConfigArraySymbol } = require("@humanwhocodes/config-array");
  * @property {number} [endLine] The 1-based line number of the reported end location.
  * @property {number} [endColumn] The 1-based column number of the reported end location.
  */
-/* eslint-enable jsdoc/valid-types -- https://github.com/jsdoc-type-pratt-parser/jsdoc-type-pratt-parser/issues/4#issuecomment-778805577 */
 
 //------------------------------------------------------------------------------
 // Private Members

diff --git a/lib/rule-tester/rule-tester.js b/lib/rule-tester/rule-tester.js
@@ -63,7 +63,7 @@ const { SourceCode } = require("../source-code");
 
 /** @typedef {import("../shared/types").Parser} Parser */
 
-/* eslint-disable jsdoc/valid-types -- https://github.com/jsdoc-type-pratt-parser/jsdoc-type-pratt-parser/issues/4#issuecomment-778805577 */
+
 /**
  * A test case that is expected to pass lint.
  * @typedef {Object} ValidTestCase
@@ -108,7 +108,6 @@ const { SourceCode } = require("../source-code");
  * @property {number} [endLine] The 1-based line number of the reported end location.
  * @property {number} [endColumn] The 1-based column number of the reported end location.
  */
-/* eslint-enable jsdoc/valid-types -- https://github.com/jsdoc-type-pratt-parser/jsdoc-type-pratt-parser/issues/4#issuecomment-778805577 */
 
 //------------------------------------------------------------------------------
 // Private Members

diff --git a/packages/eslint-config-eslint/default.yml b/packages/eslint-config-eslint/default.yml
@@ -90,12 +90,13 @@ rules:
     # jsdoc: adopt non-recommended rules or change recommended configuration
     # jsdoc/check-examples: "error"
     # jsdoc/check-indentation: "error" # Revisit if allowing configurable spaces after tag line breaks
-    jsdoc/check-line-alignment: ["error", "never"]
+    # jsdoc/check-line-alignment: ["error", "never"]
     jsdoc/check-syntax: "error"
     # jsdoc/check-types': ["error', { exemptTagContexts: [ { tag: "typedef", types: ["object", "GenericObject"] } ] }
 
     jsdoc/check-values: ["error", { allowedLicenses: true }]
     jsdoc/no-bad-blocks: "error"
+    jsdoc/no-defaults: "off"
     jsdoc/require-asterisk-prefix: "error"
     jsdoc/require-description: ["error", { checkConstructors: false }]
     # jsdoc/require-file-overview: "error"