feat: account for backports when calculating versions #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for new-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kecrily
approved these changes
Jan 29, 2024
nzakas
reviewed
Jan 29, 2024
| @@ -57,8 +57,12 @@ async function fetchStatsFromGitHubAPI() { | |||
| } | |||
| }); | |||
|
|
|||
| const [currentRelease] = repository.releases.nodes; | |||
| const latestRelease = repository.releases.nodes.find(({ isPrerelease }) => !isPrerelease); | |||
| const releases = repository.releases.nodes.toSorted( | |||
There was a problem hiding this comment.
Can you add a comment explaining why we're doing this?
There was a problem hiding this comment.
I've now added a comment explaining this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Updates logic that calculates ESLint versions for the eslint.org homepage to account for backport versions.
What changes did you make? (Give an overview)
Updated
tools/fetch-stats.jsto sort fetched releases bysemver.rcomparebefore proceeding with the calculations. This specifically account for the case that the most recently published version is a backport.Related Issues
eslint/eslint#17966
Is there anything you'd like reviewers to focus on?