Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Add missing deprecated/replacedBy properties to meta-property-ordering rule #320

Merged
merged 2 commits into from
Apr 9, 2024
Merged

feat!: Add missing deprecated/replacedBy properties to meta-property-ordering rule #320

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad20838
breaking: add missing deprecated/replacedBy properties to meta-proper…
bmish Oct 21, 2022
afac255
Merge branch 'main' into meta-property-ordering-missing-deprecated-re…
bmish Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/rules/meta-property-ordering.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ This rule enforces that meta properties of a rule are placed in a consistent ord

This rule has an array option:

* `['type', 'docs', 'fixable', 'hasSuggestions', 'schema', 'messages', 'deprecated', 'replacedBy']` (default): The order that the properties of `meta` should be placed in.
* `['type', 'docs', 'fixable', 'hasSuggestions', 'deprecated', 'replacedBy', 'schema', 'messages']` (default): The order that the properties of `meta` should be placed in.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo, the two props should be highlighted, what do you think change them to be in the 1st place?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I would be open to that.


Examples of **incorrect** code for this rule:

Expand Down
2 changes: 2 additions & 0 deletions lib/rules/meta-property-ordering.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ module.exports = {
'docs',
'fixable',
'hasSuggestions',
'deprecated',
'replacedBy',
'schema',
'messages',
];
Expand Down