Fix behaviour on Windows pre- Gleam 0.23 #166
Merged
+61
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return "${THIS_VSN}" -eq "nightly" -or (Version-Greater-Than "${THIS_VSN}" "0.22.1") | ||
| } | ||
|
|
||
| if (Uses-LLVM-Triplets "$VSN") { |
There was a problem hiding this comment.
Similar to what was done for the Linux script counterpart.
| @@ -9,12 +9,13 @@ FILE_OUTPUT=gleam.tar.gz | |||
| DIR_FOR_BIN=.setup-beam/gleam | |||
There was a problem hiding this comment.
Changed for simple diff.-related consistency
| @@ -4,14 +4,17 @@ $ErrorActionPreference="Stop" | |||
|
|
|||
There was a problem hiding this comment.
Changed for simple diff.-related consistency
| - gleam-version: '0.23.0-rc1' | ||
| otp-version: '24' | ||
| rebar3-version: '3.16' |
There was a problem hiding this comment.
This was a remain from a previous pull request, that's not actually required.
| @@ -41,9 +41,11 @@ jobs: | |||
| otp-version: '24' | |||
| rebar3-version: '3.15' | |||
| os: 'windows-latest' | |||
| - gleam-version: '0.19.0-rc3' | |||
There was a problem hiding this comment.
For this version, without the change, CI would fail.
After my change: ✅
Before my change: ❌
(workflow file: https://github.com/paulo-ferraz-oliveira/setup-beam-example/actions/runs/3672093082/workflow)
starbelly
approved these changes
Dec 14, 2022
paulo-ferraz-oliveira
deleted the
feature/gleam-support-on-windows-for-pre-0.23
branch
paulo-ferraz-oliveira
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanna try and close #140, so want to first identify the issue then tackle it. Opening, initially, as draft.