Test on top of Erlang/OTP 25+ (not RC) #118
Merged
+26
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
This was done because of a test to an issue, a few minutes ago. In any case, it's an extra confidence boost 😄 |
And a strict version
We weren't taking our own considerations into account for version strictness We want to be able to test cases where we use -otp- (if the consumer is doing it, at least they have to use _strict_ to assert their decision)
| @@ -6193,7 +6193,7 @@ async function getOTPVersion(otpSpec0, osVersion) { | |||
| const otpVersions = await getOTPVersions(osVersion) | |||
| const otpSpec = otpSpec0.match(/^(OTP-)?([^ ]+)/) | |||
| let otpVersion | |||
| if (otpSpec[1]) { | |||
| if (otpSpec[1] && !isStrictVersion()) { | |||
There was a problem hiding this comment.
This was just us being super strict with input, but for the edge case being tested we do want to allow "Using -otp- or OTP-", even though it is to be made explicit via the version-type option.
starbelly
approved these changes
May 26, 2022
|
@paulo-ferraz-oliveira Approved, but left it open so you can squash as you like. |
kianmeng
added a commit
to kianmeng/setup-beam
that referenced
this pull request
Jun 11, 2022
kianmeng
added a commit
to kianmeng/setup-beam
that referenced
this pull request
Jun 25, 2022
paulo-ferraz-oliveira
pushed a commit
that referenced
this pull request
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.