Fix incorrect carrier count statistics after using instrument module #8636
+209
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpool.stat.no_carriers was decremented when dummy carrier was deleted but not incremented at insert in blockscan_save_cpool_cursor(). Make pure cpool_link/unlink functions without any carrier stats update to be called directly by blockscan to link/unlink its dummy carrier.
After unlinking a pooled carrier, thread progress must pass before we can safely free it or re-insert it into the pool. This also applies for the dummy carriers used to mark progress during yield. Solved by scheduling thread progress at each yield of blockscan and switching between two dummy carriers (dumb and dumber).
sverker
added
team:VM
CT Test Results 3 files 143 suites 49m 3s ⏱️ Results for commit d63d656. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of carriers in a shared pool (
allctr->cpool.stat.no_carriers) was decremented every time a call toinstrument:allocationsorinstrument:carriersyielded while traversing the pool.Also make sure to not free or re-insert a yield cursor (dummy carrier) into shared carrier pool until thread progress has passed.