Merge pull request #531 from ergebnis/feature/php72

Enhancement: Add support for PHP 7.2
ergebnis · Apr 7, 2024 · b9064d6 · b9064d6
2 parents 6cdc6ef + 8a174aa
commit b9064d6
Show file tree

Hide file tree

Showing 129 changed files with 301 additions and 275 deletions.
diff --git a/.github/settings.yml b/.github/settings.yml
@@ -21,10 +21,14 @@ branches:
           - context: "Refactoring (7.4, locked)"
           - context: "Security Analysis (7.4, locked)"
           - context: "Static Code Analysis (7.4, locked)"
+          - context: "Tests (7.5.0, 7.2, highest)"
+          - context: "Tests (7.5.0, 7.2, lowest)"
           - context: "Tests (7.5.0, 7.3, highest)"
           - context: "Tests (7.5.0, 7.3, lowest)"
           - context: "Tests (7.5.0, 7.4, highest)"
           - context: "Tests (7.5.0, 7.4, lowest)"
+          - context: "Tests (8.5.19, 7.2, highest)"
+          - context: "Tests (8.5.19, 7.2, lowest)"
           - context: "Tests (8.5.19, 7.3, highest)"
           - context: "Tests (8.5.19, 7.3, lowest)"
           - context: "Tests (8.5.19, 7.4, highest)"

diff --git a/.github/workflows/integrate.yaml b/.github/workflows/integrate.yaml
@@ -460,6 +460,7 @@ jobs:
           - "7.5.0"
 
         php-version:
+          - "7.2"
           - "7.3"
           - "7.4"
 
@@ -468,6 +469,14 @@ jobs:
           - "highest"
 
         include:
+          - phpunit-version: "8.5.19"
+            php-version: "7.2"
+            dependencies: "lowest"
+
+          - phpunit-version: "8.5.19"
+            php-version: "7.2"
+            dependencies: "highest"
+
           - phpunit-version: "8.5.19"
             php-version: "7.3"
             dependencies: "lowest"

diff --git a/.php-cs-fixer.php b/.php-cs-fixer.php
@@ -26,7 +26,7 @@
 
 $license->save();
 
-$ruleSet = PhpCsFixer\Config\RuleSet\Php73::create()
+$ruleSet = PhpCsFixer\Config\RuleSet\Php72::create()
     ->withHeader($license->header())
     ->withRules(PhpCsFixer\Config\Rules::fromArray([
         'mb_str_functions' => false,

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 For a full diff see [`2.11.0...main`][2.11.0...main].
 
+### Changed
+
+- Added support for PHP 7.2 ([#531]), by [@localheinz]
+
 ## [`2.11.0`][2.11.0]
 
 For a full diff see [`2.10.0...2.11.0`][2.10.0...2.11.0].
@@ -291,6 +295,7 @@ For a full diff see [`7afa59c...1.0.0`][7afa59c...1.0.0].
 [#491]: https://github.com/ergebnis/phpunit-slow-test-detector/pull/491
 [#494]: https://github.com/ergebnis/phpunit-slow-test-detector/pull/494
 [#495]: https://github.com/ergebnis/phpunit-slow-test-detector/pull/495
+[#531]: https://github.com/ergebnis/phpunit-slow-test-detector/pull/531
 
 [@HypeMC]: https://github.com/HypeMC
 [@localheinz]: https://github.com/localheinz

diff --git a/composer.json b/composer.json
@@ -24,7 +24,7 @@
     "security": "https://github.com/ergebnis/phpunit-slow-test-detector/blob/main/.github/SECURITY.md"
   },
   "require": {
-    "php": "~7.3.0 || ~7.4.0 || ~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0",
+    "php": "~7.2.0 || ~7.3.0 || ~7.4.0 || ~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0",
     "phpunit/phpunit": "^7.5.0 || ^8.5.19 || ^9.0.0 || ^10.0.0 || ^11.0.0"
   },
   "require-dev": {

diff --git a/composer.lock b/composer.lock
diff --git a/rector.php b/rector.php
@@ -23,5 +23,5 @@
         __DIR__ . '/test/',
     ]);
 
-    $rectorConfig->phpVersion(ValueObject\PhpVersion::PHP_73);
+    $rectorConfig->phpVersion(ValueObject\PhpVersion::PHP_72);
 };
diff --git a/src/Duration.php b/src/Duration.php
@@ -57,13 +57,13 @@ public static function fromSecondsAndNanoseconds(
         if ($maxNanoseconds < $nanoseconds) {
             throw Exception\InvalidNanoseconds::notLessThanOrEqualTo(
                 $nanoseconds,
-                $maxNanoseconds,
+                $maxNanoseconds
             );
         }
 
         return new self(
             $seconds,
-            $nanoseconds,
+            $nanoseconds
         );
     }
 
@@ -78,14 +78,14 @@ public static function fromMilliseconds(int $milliseconds): self
 
         $seconds = \intdiv(
             $milliseconds,
-            1000,
+            1000
         );
 
         $nanoseconds = ($milliseconds - $seconds * 1000) * 1000000;
 
         return new self(
             $seconds,
-            $nanoseconds,
+            $nanoseconds
         );
     }
 
@@ -107,13 +107,13 @@ public function add(self $other): self
         if (999999999 < $nanoseconds) {
             return new self(
                 $seconds + 1,
-                $nanoseconds - 1000000000,
+                $nanoseconds - 1000000000
             );
         }
 
         return new self(
             $seconds,
-            $nanoseconds,
+            $nanoseconds
         );
     }
 

diff --git a/src/Exception/InvalidCount.php b/src/Exception/InvalidCount.php
@@ -22,7 +22,7 @@ public static function notGreaterThanZero(int $value): self
     {
         return new self(\sprintf(
             'Value should be greater than 0, but %d is not.',
-            $value,
+            $value
         ));
     }
 }
diff --git a/src/Exception/InvalidMilliseconds.php b/src/Exception/InvalidMilliseconds.php
@@ -22,7 +22,7 @@ public static function notGreaterThanZero(int $value): self
     {
         return new self(\sprintf(
             'Value should be greater than 0, but %d is not.',
-            $value,
+            $value
         ));
     }
 }
diff --git a/src/Exception/InvalidNanoseconds.php b/src/Exception/InvalidNanoseconds.php
@@ -22,7 +22,7 @@ public static function notGreaterThanOrEqualToZero(int $value): self
     {
         return new self(\sprintf(
             'Value should be greater than or equal to 0, but %d is not.',
-            $value,
+            $value
         ));
     }
 
@@ -33,7 +33,7 @@ public static function notLessThanOrEqualTo(
         return new self(\sprintf(
             'Value should be less than or equal to %d, but %d is not.',
             $two,
-            $one,
+            $one
         ));
     }
 }
diff --git a/src/Exception/InvalidSeconds.php b/src/Exception/InvalidSeconds.php
@@ -22,15 +22,15 @@ public static function notGreaterThanZero(int $value): self
     {
         return new self(\sprintf(
             'Value should be greater than 0, but %d is not.',
-            $value,
+            $value
         ));
     }
 
     public static function notGreaterThanOrEqualToZero(int $value): self
     {
         return new self(\sprintf(
             'Value should be greater than or equal to 0, but %d is not.',
-            $value,
+            $value
         ));
     }
 }
diff --git a/src/Exception/PhaseNotStarted.php b/src/Exception/PhaseNotStarted.php
@@ -24,7 +24,7 @@ public static function fromPhaseIdentifier(PhaseIdentifier $phaseIdentifier): se
     {
         return new self(\sprintf(
             'Phase identified by "%s" has not been started.',
-            $phaseIdentifier->toString(),
+            $phaseIdentifier->toString()
         ));
     }
 }
diff --git a/src/Extension.php b/src/Extension.php
@@ -22,7 +22,7 @@
 } catch (\InvalidArgumentException $exception) {
     throw new \RuntimeException(\sprintf(
         'Unable to determine PHPUnit version from version series "%s".',
-        Runner\Version::series(),
+        Runner\Version::series()
     ));
 }
 
@@ -75,7 +75,7 @@ public function __construct(array $options = [])
             $this->reporter = new Reporter\DefaultReporter(
                 new Formatter\DefaultDurationFormatter(),
                 $maximumDuration,
-                $maximumCount,
+                $maximumCount
             );
         }
 
@@ -105,7 +105,7 @@ public function executeAfterTest(
 
             $duration = Duration::fromSecondsAndNanoseconds(
                 $seconds,
-                $nanoseconds,
+                $nanoseconds
             );
 
             $maximumDuration = $this->resolveMaximumDuration($test);
@@ -119,7 +119,7 @@ public function executeAfterTest(
             $slowTest = SlowTest::create(
                 $testIdentifier,
                 $duration,
-                $maximumDuration,
+                $maximumDuration
             );
 
             $this->collector->collect($slowTest);
@@ -156,7 +156,7 @@ private function resolveMaximumDuration(string $test): Duration
         {
             [$testClassName, $testMethodName] = \explode(
                 '::',
-                $test,
+                $test
             );
 
             $annotations = [
@@ -166,7 +166,7 @@ private function resolveMaximumDuration(string $test): Duration
 
             $symbolAnnotations = Util\Test::parseTestMethodAnnotations(
                 $testClassName,
-                $testMethodName,
+                $testMethodName
             );
 
             foreach ($annotations as $annotation) {
@@ -230,20 +230,20 @@ public function bootstrap(
             $reporter = new Reporter\DefaultReporter(
                 new Formatter\DefaultDurationFormatter(),
                 $maximumDuration,
-                $maximumCount,
+                $maximumCount
             );
 
             $facade->registerSubscribers(
                 new Subscriber\Test\PreparationStartedSubscriber($timeKeeper),
                 new Subscriber\Test\FinishedSubscriber(
                     $maximumDuration,
                     $timeKeeper,
-                    $collector,
+                    $collector
                 ),
                 new Subscriber\TestRunner\ExecutionFinishedSubscriber(
                     $collector,
-                    $reporter,
-                ),
+                    $reporter
+                )
             );
         }
     }
@@ -253,5 +253,5 @@ public function bootstrap(
 
 throw new \RuntimeException(\sprintf(
     'Unable to select extension for PHPUnit version with version series "%s".',
-    Runner\Version::series(),
+    Runner\Version::series()
 ));
diff --git a/src/Formatter/DefaultDurationFormatter.php b/src/Formatter/DefaultDurationFormatter.php
@@ -46,7 +46,7 @@ public function format(Duration $duration): string
                 $hours,
                 $minutes,
                 $seconds,
-                $milliseconds,
+                $milliseconds
             );
         }
 
@@ -55,14 +55,14 @@ public function format(Duration $duration): string
                 '%d:%02d.%03d',
                 $minutes,
                 $seconds,
-                $milliseconds,
+                $milliseconds
             );
         }
 
         return \sprintf(
             '%d.%03d',
             $seconds,
-            $milliseconds,
+            $milliseconds
         );
     }
 }
diff --git a/src/Phase.php b/src/Phase.php
@@ -59,7 +59,7 @@ public static function create(
             $phaseIdentifier,
             $startTime,
             $stopTime,
-            $stopTime->duration($startTime),
+            $stopTime->duration($startTime)
         );
     }
 

diff --git a/src/PhaseStart.php b/src/PhaseStart.php
@@ -42,7 +42,7 @@ public static function create(
     ): self {
         return new self(
             $phaseIdentifier,
-            $startTime,
+            $startTime
         );
     }