add newlines to GinkgoLogr (onsi#1170)

erdnas · Mar 27, 2023 · 6dc258e · 6dc258e
1 parent 9b5078f
commit 6dc258e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/internal/writer.go b/internal/writer.go
@@ -135,6 +135,6 @@ func (w *Writer) Println(a ...interface{}) {
 
 func GinkgoLogrFunc(writer *Writer) logr.Logger {
 	return funcr.New(func(prefix, args string) {
-		writer.Printf("%s", args)
+		writer.Printf("%s\n", args)
 	}, funcr.Options{})
 }
diff --git a/internal/writer_test.go b/internal/writer_test.go
@@ -124,18 +124,24 @@ var _ = Describe("Writer", func() {
 			Ω(string(out.Contents())).Should(Equal("  foo17 - bar\n"))
 		})
 	})
-
 	When("wrapped by logr", func() {
 		It("can print Info logs", func() {
 			log := internal.GinkgoLogrFunc(writer)
 			log.Info("message", "key", 5)
-			Ω(string(out.Contents())).Should(Equal("  \"level\"=0 \"msg\"=\"message\" \"key\"=5"))
+			Ω(string(out.Contents())).Should(Equal("  \"level\"=0 \"msg\"=\"message\" \"key\"=5\n"))
 		})
 
 		It("can print Error logs", func() {
 			log := internal.GinkgoLogrFunc(writer)
 			log.Error(errors.New("cake"), "planned failure", "key", "banana")
-			Ω(string(out.Contents())).Should(Equal("  \"msg\"=\"planned failure\" \"error\"=\"cake\" \"key\"=\"banana\""))
+			Ω(string(out.Contents())).Should(Equal("  \"msg\"=\"planned failure\" \"error\"=\"cake\" \"key\"=\"banana\"\n"))
+		})
+
+		It("can print multiple logs", func() {
+			log := internal.GinkgoLogrFunc(writer)
+			log.Info("message", "key", 5)
+			log.Error(errors.New("cake"), "planned failure", "key", "banana")
+			Ω(string(out.Contents())).Should(Equal("  \"level\"=0 \"msg\"=\"message\" \"key\"=5\n  \"msg\"=\"planned failure\" \"error\"=\"cake\" \"key\"=\"banana\"\n"))
 		})
 	})
 })