Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Go dependencies, removed deprecated pkgs #2694

Merged
merged 2 commits into from Nov 14, 2023

Conversation

enrichman
Copy link
Member

@enrichman enrichman commented Nov 14, 2023

Fix #2691

This PR updates a lot of Go dependencies, updating and removing also some deprecated packages.

EDIT:
the update og gin to the v1.9.x from v1.8 bring the yaml.v3 gin-gonic/gin#3456

I had to update the tests to match the different spaces: https://github.com/gin-gonic/gin/pull/3456/files#diff-3fad6a4644fd108e20ba48a771dc99faff1f5efe4aa137e5b5869e3402ea7eca

@enrichman enrichman added this to the v1.11.0 milestone Nov 14, 2023
@enrichman enrichman self-assigned this Nov 14, 2023
@enrichman enrichman marked this pull request as ready for review November 14, 2023 13:30
@enrichman enrichman requested a review from a team as a code owner November 14, 2023 13:30
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (17e99da) 67.15% compared to head (b888cac) 66.75%.
Report is 7 commits behind head on main.

Files Patch % Lines
internal/cli/cmd/exportregistry.go 42.85% 7 Missing and 1 partial ⚠️
internal/cli/cmd/version.go 50.00% 3 Missing and 1 partial ⚠️
internal/api/v1/application/export.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2694      +/-   ##
==========================================
- Coverage   67.15%   66.75%   -0.41%     
==========================================
  Files         210      210              
  Lines       18486    18474      -12     
==========================================
- Hits        12415    12333      -82     
- Misses       4998     5040      +42     
- Partials     1073     1101      +28     
Flag Coverage Δ
acceptance-api 46.56% <62.16%> (-0.31%) ⬇️
acceptance-apps 36.64% <62.16%> (+0.12%) ⬆️
acceptance-cli 62.71% <64.86%> (-0.32%) ⬇️
unittests 14.34% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enrichman enrichman merged commit d8182bf into main Nov 14, 2023
17 checks passed
@enrichman enrichman deleted the go-dependencies-update branch November 14, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update Go dependencies
2 participants