Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change icon name in VaInnerLoading #3857

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

Alazar351
Copy link
Contributor

@Alazar351 Alazar351 commented Sep 11, 2023

Description

In VaInnerLoading component the icon name autorenew was changed to va-loading.
closes #3830

Markup:

   - icon: { type: String, default: 'autorenew' },
   + icon: { type: String, default: 'va-loading' },

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@Alazar351 Alazar351 changed the title fixes #3830 fixe: Change icon name in VaInnerLoading Sep 11, 2023
@Alazar351 Alazar351 changed the title fixe: Change icon name in VaInnerLoading fix: Change icon name in VaInnerLoading Sep 11, 2023
@m0ksem
Copy link
Contributor

m0ksem commented Sep 12, 2023

Thanks!

@m0ksem m0ksem merged commit 3b4f8c1 into epicmaxco:develop Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The VaInnerLoading component uses the icon name autorenew insread of va-loading
2 participants