Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Trait documenter tests for Sphinx >= 7.2 #1755

Merged
merged 1 commit into from Sep 11, 2023
Merged

Fix Trait documenter tests for Sphinx >= 7.2 #1755

merged 1 commit into from Sep 11, 2023

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Sep 5, 2023 •
edited

This PR fixes the Trait documenter test for Sphinx >= 7.2. For that version of Sphinx, the srcdir argument to SphinxTestApp needs to be a pathlib.Path object rather than a sphinx.testing.path.path object.

Closes #1754

@mdickinson mdickinson mentioned this pull request Sep 5, 2023
Merged
@mdickinson mdickinson merged commit f644cc2 into main Sep 11, 2023
27 checks passed
@mdickinson mdickinson deleted the fix/sphinx-documenter-paths branch September 11, 2023 16:22
mdickinson added a commit that referenced this pull request Oct 9, 2023
@mdickinson
Release Traits 6.4.3 (#1756)
6cc4e9e 
This PR:

- backports PR #1755 to the release branch
- updates the version and changelog in preparation for a Traits 6.4.3
release

EDIT: Updated 2023-09-11 to backport PRs #1757  and #1758.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddhantwahal siddhantwahal siddhantwahal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sphinx 7.2 breaks trait documenter tests
2 participants
@mdickinson @siddhantwahal