Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateRoleParams displayName is optional but throws NPE #10486 #10496

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

alansemenov
Copy link
Member

Made behaviour in createUser and createRole consistent with createGroup: use name when displayName is omitted

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.51%. Comparing base (c80742c) to head (02de453).

Files Patch % Lines
...java/com/enonic/xp/lib/auth/CreateRoleHandler.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10496      +/-   ##
============================================
- Coverage     84.52%   84.51%   -0.01%     
- Complexity    19680    19682       +2     
============================================
  Files          2613     2613              
  Lines         68385    68388       +3     
  Branches       5460     5462       +2     
============================================
+ Hits          57799    57801       +2     
  Misses         7948     7948              
- Partials       2638     2639       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alansemenov alansemenov merged commit b2152bc into master Apr 4, 2024
9 checks passed
@alansemenov alansemenov deleted the issue-10486 branch April 4, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CreateRoleParams displayName is optional, but throws java.lang.NullPointerException
3 participants