Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10478 out of scope for system provider #10479

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

rymsha
Copy link
Contributor

@rymsha rymsha commented Mar 22, 2024

No description provided.

@rymsha rymsha linked an issue Mar 22, 2024 that may be closed by this pull request
@rymsha rymsha changed the base branch from master to 7.14 March 22, 2024 15:57
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 79.06977% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 84.45%. Comparing base (27d5cb3) to head (8c83169).
Report is 1 commits behind head on 7.14.

Files Patch % Lines
.../com/enonic/xp/portal/handler/BaseSiteHandler.java 30.76% 7 Missing and 2 partials ⚠️
...c/xp/admin/impl/portal/AdminToolPortalHandler.java 22.22% 4 Missing and 3 partials ⚠️
...p/portal/impl/idprovider/PortalRequestAdapter.java 91.46% 4 Missing and 3 partials ⚠️
.../enonic/xp/admin/impl/portal/AdminToolHandler.java 50.00% 0 Missing and 1 partial ⚠️
.../main/java/com/enonic/xp/portal/PortalRequest.java 0.00% 0 Missing and 1 partial ⚠️
...p/portal/impl/exception/ExceptionRendererImpl.java 0.00% 0 Missing and 1 partial ⚠️
...nic/xp/portal/impl/handler/portal/SiteHandler.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               7.14   #10479   +/-   ##
=========================================
  Coverage     84.45%   84.45%           
- Complexity    19540    19546    +6     
=========================================
  Files          2604     2604           
  Lines         67993    68043   +50     
  Branches       5397     5411   +14     
=========================================
+ Hits          57423    57468   +45     
+ Misses         7962     7961    -1     
- Partials       2608     2614    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rymsha rymsha force-pushed the 10478-out-of-scope-for-system-provider branch from 0e1c5a8 to 0a91c11 Compare March 26, 2024 09:35
@rymsha rymsha force-pushed the 10478-out-of-scope-for-system-provider branch from d8264ec to 8c83169 Compare April 2, 2024 13:15
@rymsha rymsha marked this pull request as ready for review April 2, 2024 13:31
@rymsha rymsha merged commit 5dc120e into 7.14 Apr 2, 2024
5 of 6 checks passed
@rymsha rymsha deleted the 10478-out-of-scope-for-system-provider branch April 2, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Out of scope for system provider
3 participants