Use name as a nodeId for ScheduledJob #10482

enonic · Mar 26, 2024 · 8f501fb · 8f501fb
1 parent 61906d4
commit 8f501fb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/.../core-scheduler/src/main/java/com/enonic/xp/impl/scheduler/CreateScheduledJobCommand.java b/.../core-scheduler/src/main/java/com/enonic/xp/impl/scheduler/CreateScheduledJobCommand.java
@@ -37,8 +37,7 @@ private ScheduledJob doExecute()
     {
         final PropertyTree data = SchedulerSerializer.toCreateNodeData( params );
 
-        final CreateNodeParams createNodeParams = CreateNodeParams.create().
-            setNodeId( new NodeId() ).
+        final CreateNodeParams createNodeParams = CreateNodeParams.create().setNodeId( NodeId.from( params.getName().getValue() ) ).
             name( params.getName().getValue() ).
             data( data ).
             parent( NodePath.ROOT ).

diff --git a/...itest/itest-core/src/test/java/com/enonic/xp/core/scheduler/SchedulerServiceImplTest.java b/...itest/itest-core/src/test/java/com/enonic/xp/core/scheduler/SchedulerServiceImplTest.java
@@ -28,7 +28,7 @@
 import com.enonic.xp.impl.scheduler.SchedulerServiceImpl;
 import com.enonic.xp.impl.scheduler.UpdateLastRunCommand;
 import com.enonic.xp.node.NodeAccessException;
-import com.enonic.xp.node.NodeAlreadyExistAtPathException;
+import com.enonic.xp.node.NodeIdExistsException;
 import com.enonic.xp.node.NodeNotFoundException;
 import com.enonic.xp.page.DescriptorKey;
 import com.enonic.xp.scheduler.CreateScheduledJobParams;
@@ -219,7 +219,7 @@ void createExisted()
 
         adminContext().runWith( () -> schedulerService.create( params ) );
 
-        assertThrows( NodeAlreadyExistAtPathException.class, () -> adminContext().runWith( () -> schedulerService.create( params ) ) );
+        assertThrows( NodeIdExistsException.class, () -> adminContext().runWith( () -> schedulerService.create( params ) ) );
     }
 
     @Test