Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency @ckeditor/ckeditor5-theme-lark to v40 #7

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Update dependency @ckeditor/ckeditor5-theme-lark to v40 #7

merged 1 commit into from
Dec 12, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 12, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@ckeditor/ckeditor5-theme-lark (source) ^34.2.0 -> ^40.0.0 age adoption passing confidence

Release Notes

ckeditor/ckeditor5 (@​ckeditor/ckeditor5-theme-lark)

v40.2.0

Compare Source

We are happy to announce the release of CKEditor 5 v40.2.0.

Release highlights
AI Assistant: AWS and custom integrations

Enabling multiple AI model service was one of our priorities for the AI Assistant, as we wanted everyone to be able to use a platform that they find the most convenient.

We are happy to inform that as of this release, you can use the AI Assistant together with the AWS Bedrock service.

What is more, you can now extend existing adapters to enable more advanced customizations, such as decorating the AI Assistant requests.

Finally, you can even provide your own custom adapter to connect to your own model, or any model that does not have an official adapter yet.

Visit our new integration guide to learn more about integrating and customizing the AI Assistant feature.

Note that these improvements come with minor breaking changes in the editor configuration, so make sure to visit the breaking changes section and the update guide.

Image editing

CKBox’s image editing capabilities, introduced in CKBox v1.6.0, are now accessible straight from the CKEditor image toolbar. CKBox users can resize, crop or rotate images right within CKEditor.

Additionally, you can also edit images which are not yet added to CKBox (for example hotlinked images). CKBox will automatically download the images in the background, to allow users to edit them without having to leave CKEditor to manually add the image into CKBox. This dual functionality, combined with server-side processing, ensures ease of use and maintains high image quality and file integrity, providing a more efficient and reliable image editing experience within CKEditor.

Please refer to the update guide to learn more about these changes.

(Experimental) Paste Markdown

This release introduces the new Paste Markdown feature. It will automatically format any raw Markdown source or output copied and pasted directly into the editor – without having to switch to source editing. This feature is in its experimental phase, and its behavior may change in the future. Experience this functionality firsthand by pasting Markdown content into the demo editor. We welcome your feedback and observations for ongoing improvements, so please share them in the GitHub issue.

(Coming soon!) New installation methods

We are excited to announce upcoming improvements to CKEditor 5's installation process, set to release next year. Our goal is to address and resolve the accumulated pain points that you experienced over the years. For a detailed overview of our plans and the background behind them, dive into our comprehensive proposal in the RFC. Your feedback is crucial in refining and perfecting these improvements, and we eagerly await your input!

Other notable improvements
  • Improved insert image button: our insertImage component now supports file managers, and automatically detects if you are using CKBox. We also changed the default icon for upload image from computer to better indicate it’s an upload action, not a generic image button.
  • Paste link over text: the editor automatically converts selected text to a link when you paste a URL onto it.
MINOR BREAKING CHANGES ℹ️
  • ai: The configuration for AI Assistant has changed and will require an update. Additionally, a proper adapter (OpenAIAdapter, AWSAdapter, or a custom adapter) must be now explicitly added to the plugin list. See the update guide for details.
  • image: The ImageInsertUI plugin internals were cleaned up, as it worked a bit magically with hard-coded dependencies. For example, it automatically enabled the behavior of inserting image via URL. As of now, it will not enable any external behaviors. See the update guide for details.
  • list: The CollapsibleView has been moved from the @ckeditor/ckeditor5-list package to @ckeditor/ckeditor5-ui. You can import it like this: import { CollapsibleView } from '@​ckeditor/ckeditor5-ui';
Features

  • ai: Introduced AWS Bedrock support for AI Assistant. See AI Assistant integration guide to learn more.

  • ckbox: Enabled editing of non-CKBox images in the editor. (commit)

  • ckbox: Integrated the CKBox Image Editing feature into the editor. (commit)

  • image: Introduced the image insert dropdown as a consistent UI to insert images through different available integrations such as image upload, insert an image with the asset manager, and insert an image via URL. Closes #​15303, #​15149. (commit)

  • link: Links can now be applied by pasting a URL on a selected text. Closes #​5656. (commit)

  • markdown-gfm: Added an experimental support for pasting markdown-formatted content. Closes #​2321. (commit)

  • media-embed: Added support for short Dailymotion URLs (dai.ly) in media-embed. (commit)

    Thanks to @​Kocal!

Bug fixes
  • ai: The fake selection marker was not always properly removed when AI Assistant UI was closed.
  • ai: A user prompt containing special characters was incorrectly displayed in the prompt field (special characters were incorrectly escaped).
  • ai: The AI Assistant error message should be cleared upon closing the balloon.
  • engine: Fixed crash happening in a very peculiar scenario involving reconversion of an element containing a marker. Closes #​15411. (commit)
  • html-support: DocumentSelection should not store the GHS linkA attribute if the linkHref attribute was removed by the two-step caret movement feature. Closes #​15051. (commit)
  • html-support: The editor should not crash when there is a <template> element in the content. Closes #​14933. (commit)
  • paste-from-office: Content from Word documents should be pasted correctly (without HTML styles tag content) on Windows systems. Closes #​15333, #​9002. (commit)
  • track-changes: Prevented joining two block format suggestions made on widgets placed next to each other, which was an undesirable behavior. Fixed related editor crash involving two tables with resized columns.
  • track-changes: Fixed incorrect handling of attribute suggestions made on a paragraph-like element when the element had insertion suggestion inside.
Other changes
  • ai: Introduced support for the OpenAI gpt-3.5-turbo-1106 model in AI Assistant.
  • ai: Secured AI Assistant from incorrect responses that do not being with the processed HTML.
  • ai: Introduced the AITextAdapter abstract class that can be extended to provide custom adapter for AI Assistant.
  • ai: Introduced OpenAIAdapter and AWSAdapter that can be extended to customize how AI Assistant requests and responses are handled.
  • ai: Reorganized the configuration parameters for AI Assistant. See the API documentation and migration guide.
  • ai: Allowed to fully customize request headers by providing an object or a function to requestHeaders configuration parameter. See API docs and migration guide.
  • image: The ImageUploadUI plugin is loaded by default when the ImageBlock or ImageInline plugins are loaded. See #​15149. (commit)
  • link: The logic behind the two-step caret movement extracted to the common code in the two-step caret movement feature. (commit)
  • list: The CollapsibleView class has been moved from the @ckeditor/ckeditor5-list package to @ckeditor/ckeditor5-ui. See #​15149. (commit)
  • typing: The logic behind the two-step caret movement extracted to the common code in the two-step caret movement feature. (commit)
  • typing: Unified behavior of the insertText command for cases using the DocumentSelection and Selection as applied attributes behaved differently in those cases. (commit)
  • ui: The CollapsibleView class has been moved from the @ckeditor/ckeditor5-list package to @ckeditor/ckeditor5-ui. See #​15149. (commit)
  • ui: The SplitButtonView constructor and createDropdown() helper accepts an instance of a ButtonView as an action view customization. See #​15149. (commit)
  • upload: The FileDialogButtonView class is now an instance of the ButtonView, not just a wrapper on it. See #​15149. (commit)
  • The undo and redo toolbar components described in the @ckeditor/ckeditor5-essentials/src/ckeditor5-metadata.json file are now defined in the package that registers those buttons (@ckeditor/ckeditor5-undo). Closes #​15414. (commit)
  • Updated translations. (commit, commit, commit)
Released packages

Check out the Versioning policy guide for more information.

Released packages (summary)

Major releases (contain major breaking changes):

Minor releases (contain minor breaking changes):

Releases containing new features:

Other releases:

v40.1.0

Compare Source

We are happy to announce the release of CKEditor 5 v40.1.0.

Release highlights
Styling suggestions reflected in the content

This release introduces an important user experience improvement for the track changes feature. From now on, styling changes made in the track changes mode will be also reflected in the editor content, instead of just being marked with a blue suggestion highlight.

Below is a summary of the important changes related to this improvement:

  • A new suggestion type 'attribute' was introduced. All integrated features will now create 'attribute' suggestions.
  • Formatting suggestions in existing documents are still supported, and will work as they used to.
  • With the new suggestions, multiple changes are put into a single suggestion if possible, to avoid bloating sidebar with too many annotations.
  • For asynchronous collaboration integrations, make sure that you save and provide the SuggestionData#attributes property, as it is used by the new suggestions.

We will continue further work on this improvement, including integrating the new solution with the list feature.

Azure OpenAI service support

We have introduced necessary changes to make sure that the AI Assistant can be used with the Azure OpenAI service. Please refer to the AI Assistant documentation for details.

Other notable improvements
  • Fixed triple click before widgets: the beloved triple click to select content works correctly before tables, images, and other widgets.
  • Several CKBox integration improvements include a significantly enhanced image insertion mechanism from CKBox, offering a less jumpy experience. The release also addresses key issues, such as including the proper replacement of images when URLs are edited, better focus management post-image insertion, and a fixed tokenUrl configuration for more seamless integration.
  • Paste from Office enhanced: our advanced format preserver for Office kept too many unnecessary attributes, styles, etc., in combination with General HTML support plugin. Now we fully clean up the markup before pasting.
  • Accessibility Enhancements for markers: users aided by assistive technologies will now be notified when the selection enters or leaves a comment or a suggestion in the editor content.
  • AI Assistant: the predefined commands can now be used when no content is selected (previously it was disabled). When used like this, the whole focused block (paragraph, list item, etc.) is passed as the context for the command.
  • AI Assistant: the response streaming is now configurable and can be turned off.
MINOR BREAKING CHANGES ℹ️
  • ai: The config.aiAssistant.uiCssClass configuration has been replaced by config.aiAssistant.useTheme and changed its function. A new complementary .ck-ai-assistant-ui_theme CSS class has also been introduced to the AI Assistant's UI elements. Please refer to the API documentation and the UI customization guide to learn more.
  • editor-multi-root: If you have a custom plugin that uses roots attributes, it is highly recommended to use the newly added MultiRootEditor#registerRootAttribute() method to register a custom root attribute.
  • image: By default, images are inserted as block images (not inline). To switch to the previous behavior (determining image type by insertion context), set the editor configuration image.insert.type to 'auto'.
  • import-word: Introduced the new config.importWord.formatting configuration property which is an object accepting the following properties: resets, defaults, styles, and comments. The old properties: config.importWord.defaultStyles and config.importWord.commentsStyles were removed. Use formatting.defaults and formatting.comments instead.
Features
  • ai: Enabled AI Assistant integration with the Azure OpenAI service.
  • ai: Allowed executing pre-defined AI commands on a collapsed selection.
  • ai: Allowed for ordering groups and commands in the AI Assistant's dropdown configuration through the order property. See the AIAssistantConfig API documentation for details.
  • ai: Introduced config.aiAssistant.requestParameters.stream to configure whether the AI Assistant should use streaming or not.
  • ckbox: Images inserted by CKBox should set the provided dimensions and use the blurhash to indicate image loading. Closes #​15090. (commit)
  • editor-multi-root: Added MultiRootEditor#registerRootAttribute(). All roots attributes used by features should now be registered. Roots attributes passed in editor configuration are now automatically registered. Closes #​15246. (commit)
  • image: Images inserted by CKBox should set the provided dimensions and use the blurhash to indicate image loading. Closes #​15090. (commit)
  • import-word: Introduced a new config.importWord.formatting configuration property in place of config.importWord.defaultStyles and config.importWord.commentsStyles.
  • track-changes: Styling changes made while in track changes mode will now be immediately reflected in the editor content in addition to creating a suggestion. This applies only to newly created suggestions.
  • track-changes: Introduced new suggestion type 'attribute' which indicates that an attribute on a model node has changed and allows to show the change immediately in the content.
  • ui: Introduced the AriaLiveAnnouncer class that allows for using aria-live regions to inform screen readers about changes in editor state. AriaLiveAnnouncer instance is available under EditorUI#ariaLiveAnnouncer. (commit)
Bug fixes
  • ai: The pre-defined command label should be displayed in the AI Assistant's prompt field.
  • ai: The AI content area should stop auto-scrolling once the user interacts with it.
  • ai: The AI Assistant balloon should be closed when user presses the Esc key.
  • ai: The AI pre-defined commands dropdown should reset its scroll when reopened.
  • ai: The AI Assistant should not log unnecessary warnings when detached from the DOM.
  • ai: The AI Assistant's balloon anchor point should stay at a correct position when the balloon grows.
  • ai: The AI Assistant's copy to clipboard button did not work correctly on Firefox when general HTML support plugin was loaded.
  • clipboard: Pasting a link address should not convert its parts that look like HTML entities. Closes #​15036. (commit)
  • clipboard: Improved drop marker visibility to only display in permissible drop locations. Closes #​14709. (commit)
  • comments: Prevented a crash happening when importing Word file when comments plugin is loaded.
  • core: Fixed typings in ToolbarConfig by adding an optional icon parameter. Closes #​15151. (commit)
  • html-support: Additional attributes for the link element (e.g., CSS class) should not be applied after pressing Enter. Closes #​14683. (commit)
  • image: The aspect ratio should be updated on the image replace. Closes #​15179. (commit)
  • image: Remove outdated image attributes when an image is replaced by a URL. Closes #​15093. (commit)
  • list: Pasting plain text content should not break the lists. Closes #​13826. (commit)
  • list: Pasting one list into another should preserve the target list type. See #​13826. (commit)
  • paste-from-office: Tables pasted from Word should not lose styles when GHS is enabled. (commit)
  • table: Table properties should be enabled if a table is selected from the outside. Closes #​15040, #​15041, #​10983. (commit)
  • track-changes: Editor commands will now return a proper value when executed in track changes mode.
  • ui: The AutocompleteView should not capture the Esc key press event if its result pane is hidden. (commit)
  • ui: TextareaView will no longer update its height (and log warnings) when the element is detached from DOM. (commit)
  • ui: Fixed the usage of aria-checked attribute in dropdowns. Closes #​14823. (commit)
  • utils: The Config#get() method should be able to return a function. Closes #​14804, #​12835. (commit)
  • widget: Triple-click in a paragraph should select the whole paragraph even if a block widget follows (table, block image). Closes #​11130. (commit)
  • Plugins specified in config.removePlugins should be now properly filtered out when revision history and track changes data plugins are used.
Other changes
  • ai: Simplified CSS customization in the AI Assistant's UI.
  • ai: Pre-defined commands dropdown search filter will now also include group names.
  • ai: The AI Assistant's Replace button should be labeled Insert if the selection is collapsed.
  • ai: Improved the layout of the AI Assistant in the editor using a right-to-left UI language.
  • ckbox: Should focus the editor after choosing an asset or closing CKBox. Closes #​15091. (commit)
  • ckbox: When multiple files are selected, adds each one of them in a separate paragraph. Closes #​15094. (commit)
  • ckbox: Sets the default CKBox theme to lark. Closes #​15096. (commit)
  • comments: Users using assistive technologies will be now notified when their selection enters or leaves a comment or a suggestion in the editor content.
  • core: Made the PluginInterface.destroy() method optional. (commit)
  • format-painter: Users using assistive technologies will be now notified when the formatting is being copied or pasted.
  • image: Changed the icon of the alternative text to be more accurate and describe its purposes. Closes #​12410. (commit)
  • image: Changed the default image.insert.type configuration to "block" and added the "auto" option. Closes #​15158. (commit)
  • theme-lark: Created a custom property for a shared light red color. Closes #​15217. (commit)
  • theme-lark: Improved RTL layout support in some of the UI components (FormHeaderView, ButtonView, and ListItemView). (commit)
  • track-changes: Migrated features integrations to use the 'attribute' suggestions: alignment, basic styles, font, format painter, heading, highlight, html embed, image (except for image styles), indent block, link, remove format, styles, table headings.
  • track-changes: Due to substantial changes in how new styling suggestions are presented in the editor content, numerous interactions and labels displayed in the suggestions annotations has been changed compared to the old suggestions.
  • track-changes: Users using assistive technologies will be now notified when their selection enters or leaves a comment or suggestion in the editor content.
  • ui: The ListItemGroupView should allow using a custom label. (commit)
  • ui: Improved RTL layout support in some of the UI components (FormHeaderView, ButtonView, and ListItemView). (commit)
  • Updated translations. (commit)
Released packages

Check out the Versioning policy guide for more information.

Released packages (summary)

Minor releases (contain minor breaking changes):

Releases containing new features:

Other releases:

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Dec 12, 2023

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment from CodeRabbit.
  • You can also chat with CodeRabbit bot directly around the specific lines of code or files in the PR by tagging @coderabbitai in a new comment.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Dec 12, 2023 •
edited

Apply Sweep Rules to your PR?

@renovate renovate bot force-pushed the renovate/ckeditor-ckeditor5-theme-lark-40.x branch from 217f04d to cef7875 Compare December 12, 2023 12:30
@endorphinians endorphinians merged commit 84c69b2 into main Dec 12, 2023
1 check passed
@renovate renovate bot deleted the renovate/ckeditor-ckeditor5-theme-lark-40.x branch December 12, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@endorphinians