refactor(patterns): Prepare for compression #2248
Draft
+292
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
erights
force-pushed
the
markm-prepare-for-extended-matchers
branch
from
1943903
to
896cae3
Compare
erights
changed the title
erights
added a commit
that referenced
this pull request
Apr 29, 2024
closes: #XXXX refs: #2248 #1584 Agoric/agoric-sdk#6432 ## Description Pure refactor. Changes only static info. Mostly more consistent and more readable use of `@import`. One case made less readable: Remove newlines within a large `@import` directive. The reason is that `yarn lerna run build:types` chokes on those newlines. TODO minimal repro + report issue. Extracted from other PRs #1584 #2248 which are now staged on this one. But this should be a reviewable and mergeable improvement regardless of whether we move forward on the others. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations none ### Testing Considerations none ### Compatibility Considerations none ### Upgrade Considerations none - ~[ ] Includes `*BREAKING*:` in the commit message with migration instructions for any breaking change.~ - ~[ ] Updates `NEWS.md` for user-facing changes.~
erights
force-pushed
the
markm-prepare-for-extended-matchers
branch
3 times, most recently
from
e3cfbad
to
d25cfad
Compare
erights
force-pushed
the
markm-prepare-for-extended-matchers
branch
5 times, most recently
from
aa85135
to
b619239
Compare
erights
force-pushed
the
markm-prepare-for-extended-matchers
branch
from
964d1ac
to
4c7ac33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: #XXXX
Description
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Compatibility Considerations
Upgrade Considerations
*BREAKING*:in the commit message with migration instructions for any breaking change.NEWS.mdfor user-facing changes.