define Key, PureData using parameterized Passable (WIP) #1952
+545
−440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superfluous? looks like patterns is where I meant to do this
|
@dckc I rebased #1933 on top of master so I rebased this PR on top of that. https://github.com/endojs/endo/tree/ta/dc-Passable-types has the result. I don't totally get what it buys. Does it make sense to try getting #1933 into master and coming back to this? |
turadg
force-pushed
the
1488-Passable
branch
3 times, most recently
from
1b30d60
to
ddcdad1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggestions for #1933
I think the pass-style stuff is complete. The patterns stuff is just a start.
The marshal stuff is probably superfluous.