Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated app argument passed to httpx.Client on the TestClient #2526

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Remove deprecated app argument passed to httpx.Client on the TestClient #2526

merged 1 commit into from
Feb 26, 2024

Conversation

osoken
Copy link
Contributor

@osoken osoken commented Feb 23, 2024 •
edited

Summary

Fixes: #2524
This fixes the following deprecation warning when using TestClient with httpx 0.27:

E           DeprecationWarning: The 'app' shortcut is now deprecated. Use the explicit style 'transport=WSGITransport(app=...)' instead.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@osoken osoken mentioned this pull request Feb 23, 2024
Closed
@osoken osoken changed the title fix(testclient): Remove deprecated argument in TestClient constructor Remove deprecated argument in TestClient constructor Feb 25, 2024
@Kludex
Copy link
Sponsor Member

Kludex commented Feb 26, 2024

Thanks! 🙏

@Kludex Kludex changed the title Remove deprecated argument in TestClient constructor Remove deprecated app argument passed to httpx.Client on the TestClient Feb 26, 2024
@Kludex Kludex merged commit a4cd0b5 into encode:master Feb 26, 2024
5 checks passed
nixroxursox pushed a commit to nixroxursox/starlette that referenced this pull request Mar 18, 2024
@osoken
Remove deprecated app argument passed to httpx.Client on the `Tes…
596f5fa 
…tClient` (encode#2526)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestClient DeprecationWarning with httpx 0.27.0
2 participants
@osoken @Kludex