Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add env argument to Jinja2Templates, remove **env_options. (ref #2134) #2159

Merged
merged 17 commits into from
Jun 5, 2023
Merged

Add env argument to Jinja2Templates, remove **env_options. (ref #2134) #2159

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
93d98ad
Add env argument to Jinja2Templates, remove **env_options.
alex-oleshkevich May 31, 2023
89c5d28
simplify changes
alex-oleshkevich May 31, 2023
f764843
uniform formatting in tests
alex-oleshkevich May 31, 2023
39ee96e
get back env_options
alex-oleshkevich Jun 1, 2023
7c9f4fc
warn about env_options usage
alex-oleshkevich Jun 1, 2023
5969aec
Add env argument to Jinja2Templates, remove **env_options.
alex-oleshkevich May 31, 2023
a3e8975
simplify changes
alex-oleshkevich May 31, 2023
8907911
uniform formatting in tests
alex-oleshkevich May 31, 2023
f603512
get back env_options
alex-oleshkevich Jun 1, 2023
aeb1726
warn about env_options usage
alex-oleshkevich Jun 1, 2023
15c70ed
Do not cast directory
Kludex Jun 3, 2023
abdd56d
Fix linter
Kludex Jun 3, 2023
d305e67
Use string type hint for jinja2 uninstalled environments
Kludex Jun 3, 2023
c8c2822
Merge branch 'master' into jinja-env
alex-oleshkevich Jun 5, 2023
9e00299
Merge branch 'jinja-env' of github.com:alex-oleshkevich/starlette int…
alex-oleshkevich Jun 5, 2023
06b6ba7
add overloads
alex-oleshkevich Jun 5, 2023
a2d06bc
add a link to jinja2.Environment API
alex-oleshkevich Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/templates.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ templates.env.filters['marked'] = marked_filter

## Using custom jinja2.Environment instance

Starlette also accepts a preconfigured `jinja2.Environment` instance.
Starlette also accepts a preconfigured [`jinja2.Environment`](https://jinja.palletsprojects.com/en/3.0.x/api/#api) instance.
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this doesn't render very well on mkdocs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good
image

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok. Great 👍



```python
Expand Down