Deprecate on_startup and on_shutdown events
#2070
Merged
+152
−174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Kludex
commented
Mar 9, 2023
•
Kludex
commented
- Follow-up on Alternative lifespan state api #2065
Kludex
force-pushed
the
deprecate/lifespan-events
branch
from
50376b5 to
556cc06
Compare
adriangb
approved these changes
Mar 9, 2023
starlette/routing.py
Outdated
| warnings.warn( | ||
| "The on_startup and on_shutdown parameters are deprecated, and they " | ||
| "will be removed on version 1.0. Use the lifespan parameter instead. " | ||
| "See more about it on https://www.starlette.io/events/.", |
There was a problem hiding this comment.
Should we rename this markdown file and hence the URL in this PR to avoid the link being broken in the future?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.