Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add /proc/kpagecount #232

Merged
merged 3 commits into from
Jan 23, 2023
Merged

add /proc/kpagecount #232

merged 3 commits into from
Jan 23, 2023

Conversation

tatref
Copy link
Contributor

@tatref tatref commented Jan 11, 2023

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@tatref
Copy link
Contributor Author

tatref commented Jan 15, 2023

At the moment, get_count_in_range is performing a lot of reads. I'll benchmark and try to perform a single read for the whole Vec if it's worth it.

Also, I copy pasted some code from process::pagemap, but the unbounded ranges don't make any sense (same for page map). We should raise an error if this is the case.

@eminence
Copy link
Owner

I'll benchmark and try to perform a single read for the whole Vec if it's worth it.

Do you want to hold off on the merge until this is done? Or should we merge this now, and iterate if necessary in future pull requests?

@tatref
Copy link
Contributor Author

tatref commented Jan 22, 2023

Did some testing replacing the multiple reads in the loop by a single read, but program now runs slower... I guess this is not the main bottleneck.

I think this can be merged.

One future enhancement would be to replace u64 by a new type like Pfn(u64)

@eminence eminence merged commit b9131e7 into eminence:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants