chore: Hide the close button when toastType is loading #516
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ynng3
changed the title
ynng3
changed the title
|
@emilkowalski can we have this? |
emilkowalski
added a commit
that referenced
this pull request
Feb 18, 2025
* refactor: remove unstyled prop (#557) * fix: allow toats to grow properly (#559) * chore: rename data-theme to data-sonner-theme (#560) * fix: toast removal in strict mode (#563) * refactor: maintain default styles when custom (#564) * fix: check for promise properly (#565) * chore: horizontal swiping improvements (#566) * medium font weight * chore: improve rich colors (#567) * chore: improve base colors (#568) * improve colors * improve base colors * chore: remove lift interaction, decrease default gap (#569) * v2.0.0-beta.1 * chore: update toast lifetime (#570) * build: use bunchee (#561) * fix: failing tests (#572) * Fix tests * fix tests * fix: unstyled prop not being applied to all elements (#573) * Improve unstyled prop * Cleanup * fix: inability to remove a toast that has just been created (#574) * Prevent batching * Cleanup * hero cleanup * fix: close button background is transparent (#575) * chore: bring back lift on hover (#576) * v2.0.0-beta.2 * chore: remove deprecated props (#577) * feat: drag damping (#578) * dampen darg * Adjust swipe threshold * typo * Enhance Promise to support ExternalToast propertiesfeat: Promise enhancement to allow ExternalToast props (#547) * fix: make promises work with new Error (#579) * wip * Add test for error classin promises * chore: Hide the close button when toastType is loading (#516) #514 #476 * fix close button aria labels (#490) Co-authored-by: Emil Kowalski <36730035+emilkowalski@users.noreply.github.com> * fix: error promise test (#580) * v2.0.0-beta.3 --------- Co-authored-by: Jiachi Liu <inbox@huozhi.im> Co-authored-by: Diego Traid <35971053+diegotraid@users.noreply.github.com> Co-authored-by: 알노리 <67145096+ynng3@users.noreply.github.com> Co-authored-by: Miro Rauhala <4082806+mirorauhala@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
If the toast is closed while
toastTypeisloading, the user will not be able to see the completed result.Therefore, it seems that
toastTypeis prevented from closing when it isloading.However, since there are two issues related to this, to avoid any misunderstanding, it might be better not to render the close button when the
toastTypeisloading.Therefore, I am submitting a pull request to ensure that the close button is not rendered when
toastTypeisloading.Reference
#514 #476