Fix axis labels overlap with axis ticks #57
Merged
+38
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkalte666
force-pushed
the
fix_axis_label
branch
from
ecd7104 to
07f66ed
Compare
bircni
approved these changes
Dec 4, 2024
| @@ -563,6 +563,10 @@ impl CustomAxesDemo { | |||
| ui.label("Zoom in on the X-axis to see hours and minutes"); | |||
|
|
|||
| let x_axes = vec
There was a problem hiding this comment.
I added one to the top here, so that there are axis all around the plot. This helps to show when there are issues with clipping.
emilk
approved these changes
Dec 17, 2024
emilk
added
bug
emilk
pushed a commit
that referenced
this pull request
Jan 29, 2025
<!-- Please read the "Making a PR" section of [`CONTRIBUTING.md`](https://github.com/emilk/egui_plot/blob/master/CONTRIBUTING.md) before opening a Pull Request! * Keep your PR:s small and focused. * The PR title is what ends up in the changelog, so make it descriptive! * If applicable, add a screenshot or gif. * If it is a non-trivial addition, consider adding a demo f or a new example. * Do NOT open PR:s from your `master` or `main` branch, as that makes it hard for maintainers to test and add commits to your PR. * Remember to run `cargo fmt` and `cargo clippy`. * Open the PR as a draft until you have self-reviewed it and run `./scripts/check.sh`. * When you have addressed a PR comment, mark it as resolved. Please be patient! We will review your PR, but our time is limited! --> When adding a bit longer axis labels it becomes clear that the Y axis label thickness is calculated wrong since #57. This fixes the computation. Before (current main):  After:  <!-- * Closes <https://github.com/emilk/egui_plot/issues/THE_RELEVANT_ISSUE> --> * [x] I have followed the instructions in the PR template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you have custom axis labels, you will end up with the following:
What i would expect (and what this pr does) is that the axis labels do not overlap with the ticks.
This PR does two things:
This results in the following:
A possible optimization would be to figure out the max tick thickness around the axis label, instead of using the maximal thickness - that could result in a tad smaller axis for plots where the order of magnitude changes in the current view.
However, with this PR, the issue is fixed to a level where i'd say its usable.
I have
Thanks for your time!
EDIT: as is tradition, i immediately noticed something of as soon as i wrote all this. I have updated the image and am gonna force-push a fix in a sec.
~mkalte