Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Grid now follows style.visuals.striped setting if not explicitly overwritten #3723

Merged
merged 1 commit into from Dec 23, 2023

Conversation

Wcubed
Copy link
Contributor

@Wcubed Wcubed commented Dec 19, 2023

The docs of Visuals.striped mention that they control the default striping of Grid. However, this seems to be broken.

This pr makes the Grid follow the striped setting if it doesn't yet have a row coloring set.

Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Apparently it was only used for egui_extras::Table

@emilk emilk added bug Something is broken egui labels Dec 23, 2023
@emilk emilk changed the title Grid now follows style.visuals.striped setting if not explicitly overwritten. Fix: Grid now follows style.visuals.striped setting if not explicitly overwritten Dec 23, 2023
@emilk emilk merged commit 76025f2 into emilk:master Dec 23, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken egui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants